Paywalls: new PaywallViewControllerDelegate.paywallViewController(_:didChangeSizeTo:)
#3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
reviewed
Jan 9, 2024
There was a problem hiding this comment.
🎉
Just a couple of comments from our initial prototype implementations.
Also this needs to go into the API tester: https://github.com/RevenueCat/purchases-ios/blob/main/Tests/APITesters/RevenueCatUIAPITester/SwiftAPITester/PaywallViewControllerAPI.swift#L31
Comment on lines
139
to
140
| @objc(paywallViewControlleSizeDidChange:) | ||
| optional func paywallViewControlleSizeDidChange(_ size: CGSize) |
There was a problem hiding this comment.
Let's add a doc to this and the sender controller like the others have:
Suggested change
| @objc(paywallViewControlleSizeDidChange:) | |
| optional func paywallViewControlleSizeDidChange(_ size: CGSize) | |
| /// For internal use only. | |
| @objc(paywallViewController:didChangeSize:) | |
| optional func paywallViewController(_ controller: PaywallViewController, didChangeSize size: CGSize) |
Comment on lines
75
to
78
| .onSizeChange { [weak self] in | ||
| self?.delegate?.paywallViewControlleSizeDidChange?($0) | ||
| } |
There was a problem hiding this comment.
Then this becomes:
Suggested change
| .onSizeChange { [weak self] in | |
| self?.delegate?.paywallViewControlleSizeDidChange?($0) | |
| } | |
| .onSizeChange { [weak self] in | |
| guard let self = self else { return } | |
| self.delegate?.paywallViewController(self, didChangeSize: $0) | |
| } |
There was a problem hiding this comment.
Should it be didChangeSizeWith?
NachoSoto
added
refactor
NachoSoto
changed the title
Paywalls: new PaywallViewControllerDelegate.paywallViewController(_:didChangeSize:) method
|
Changed the label to |
NachoSoto
changed the title
Paywalls: new PaywallViewControllerDelegate.paywallViewController(_:didChangeSize:) methodPaywalls: new PaywallViewControllerDelegate.paywallViewController(_:didChangeSize:)
tonidero
reviewed
Jan 10, 2024
NachoSoto
changed the title
Paywalls: new PaywallViewControllerDelegate.paywallViewController(_:didChangeSize:)Paywalls: new PaywallViewControllerDelegate.paywallViewController(_:didChangeSizeTo:)
NachoSoto
approved these changes
Jan 10, 2024
NachoSoto
pushed a commit
that referenced
this pull request
Jan 10, 2024
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: remove unscrollable spacing in Template 5 (#3562) via NachoSoto (@NachoSoto) * `Paywalls`: improve template 5 checkmark icon (#3559) via NachoSoto (@NachoSoto) ### Bugfixes * Improve sandbox detector for macOS apps (#3549) via Mark Villacampa (@MarkVillacampa) ### Other Changes * `Paywalls`: new `PaywallViewControllerDelegate.paywallViewController(_:didChangeSizeTo:)` (#3563) via Cesar de la Vega (@vegaro) * `Tests`: running tests on `macOS` (#3533) via NachoSoto (@NachoSoto) * `Integration Tests`: split into separate jobs (#3560) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
to RevenueCat/purchases-hybrid-common
that referenced
this pull request
Jan 10, 2024
Depends on RevenueCat/purchases-ios#3563 --------- Co-authored-by: NachoSoto <ignaciosoto90@gmail.com>
NachoSoto
added a commit
that referenced
this pull request
Jan 11, 2024
NachoSoto
added a commit
that referenced
this pull request
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paywallViewControlleSizeDidChangeto notify of size changes