CI: remove .framework archives from releases
#3582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
from
91de160
to
05552f5
Compare
NachoSoto
force-pushed
the
remove-carthage-archive
branch
2 times, most recently
from
5e76a83
to
7b213ea
Compare
NachoSoto
force-pushed
the
nacho/testing-circleci-m1
branch
2 times, most recently
from
f4a690a
to
6dbe2bc
Compare
NachoSoto
force-pushed
the
remove-carthage-archive
branch
2 times, most recently
from
8300ac1
to
56198c2
Compare
tonidero
approved these changes
Jan 22, 2024
| @@ -86,7 +86,7 @@ platform :ios do | |||
| repo_name: repo_name, | |||
| github_api_token: ENV["GITHUB_TOKEN"], | |||
| changelog_latest_path: changelog_latest_path, | |||
| upload_assets: ['RevenueCat.framework.zip', 'RevenueCat.xcframework.zip'] | |||
There was a problem hiding this comment.
Not sure if a lot of people are using those but just in case we should mention this in the changelog once we release this
There was a problem hiding this comment.
Yup:
remove
.frameworkarchives from releases
Also this is breaking so it'll be highlighted as a breaking change.
NachoSoto
force-pushed
the
remove-carthage-archive
branch
2 times, most recently
from
a2427f1
to
05040e6
Compare
NachoSoto
force-pushed
the
remove-carthage-archive
branch
2 times, most recently
from
d8a5fdf
to
0177c1c
Compare
MarkVillacampa
approved these changes
Feb 7, 2024
Closed
|
@MarkVillacampa feel free to merge this too |
NachoSoto
added a commit
that referenced
this pull request
Feb 7, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
NachoSoto
added a commit
that referenced
this pull request
Feb 9, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
NachoSoto
added a commit
that referenced
this pull request
Feb 9, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
NachoSoto
added a commit
that referenced
this pull request
Feb 12, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
NachoSoto
added a commit
that referenced
this pull request
Feb 12, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
NachoSoto
added a commit
that referenced
this pull request
Feb 12, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
NachoSoto
added a commit
that referenced
this pull request
Feb 12, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
NachoSoto
added a commit
that referenced
this pull request
Feb 12, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
NachoSoto
added a commit
that referenced
this pull request
Feb 14, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
NachoSoto
added a commit
that referenced
this pull request
Feb 14, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
MarkVillacampa
pushed a commit
that referenced
this pull request
Feb 21, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
MarkVillacampa
pushed a commit
that referenced
this pull request
Feb 21, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
MarkVillacampa
pushed a commit
that referenced
this pull request
Feb 21, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
joshdholtz
pushed a commit
that referenced
this pull request
Feb 23, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
joshdholtz
pushed a commit
that referenced
this pull request
Feb 23, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
MarkVillacampa
pushed a commit
that referenced
this pull request
Mar 6, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
MarkVillacampa
pushed a commit
that referenced
this pull request
Mar 6, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
MarkVillacampa
pushed a commit
that referenced
this pull request
Mar 6, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
MarkVillacampa
pushed a commit
that referenced
this pull request
Mar 6, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
MarkVillacampa
pushed a commit
that referenced
this pull request
Apr 9, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
MarkVillacampa
pushed a commit
that referenced
this pull request
Apr 9, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
fire-at-will
pushed a commit
that referenced
this pull request
Apr 15, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
fire-at-will
pushed a commit
that referenced
this pull request
Apr 15, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
fire-at-will
pushed a commit
that referenced
this pull request
May 13, 2024
[`Carthage` cannot build fat `.framework`s on Apple Silicon](https://github.com/Carthage/Carthage?tab=readme-ov-file#migrating-a-project-from-framework-bundles-to-xcframeworks): > require `XCFrameworks` when building on an Apple Silicon Mac It fails with this error: > RevenueCat have the same architectures (arm64) and can't be in the same fat output file To address that, we're planning to remove these on the next major release. Instead, `.xcframework`s, SPM, or CocoaPods should be used.
fire-at-will
pushed a commit
that referenced
this pull request
May 13, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
fire-at-will
pushed a commit
that referenced
this pull request
Jun 24, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
fire-at-will
pushed a commit
that referenced
this pull request
Jun 28, 2024
Fixes #3031. Depends on #3582. See also bielikb/fastlane-plugin-create_xcframework#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carthagecannot build fat.frameworks on Apple Silicon:It fails with this error:
To address that, we're planning to remove these on the next major release.
Instead,
.xcframeworks, SPM, or CocoaPods should be used.