Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Paywalls API tests #3697

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Add more Paywalls API tests #3697

merged 4 commits into from
Feb 20, 2024

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Feb 20, 2024

While working on #3693 I noticed we were missing some API tests that would be helpful for that PR

@vegaro vegaro added the test Adding missing tests or correcting existing tests label Feb 20, 2024
@vegaro vegaro marked this pull request as ready for review February 20, 2024 10:54
@vegaro vegaro requested a review from a team February 20, 2024 10:54
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a suggestion

purchaseStarted: self.purchaseStarted,
purchaseCompleted: self.purchaseOrRestoreCompleted,
purchaseCancelled: self.purchaseCancelled,
restoreStarted: self.restoreStarted,
restoreCompleted: self.purchaseOrRestoreCompleted,
purchaseFailure: self.failureHandler,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add one with all the parameters but nil values? Same for the footer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@vegaro vegaro enabled auto-merge (squash) February 20, 2024 11:21
@vegaro vegaro merged commit 4703e70 into main Feb 20, 2024
24 checks passed
@vegaro vegaro deleted the more-api-tests branch February 20, 2024 11:39
This was referenced Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants