Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaywallsTester: fix compilation #3753

Merged
merged 1 commit into from
Mar 12, 2024
Merged

PaywallsTester: fix compilation #3753

merged 1 commit into from
Mar 12, 2024

Conversation

aboedo
Copy link
Member

@aboedo aboedo commented Mar 6, 2024

The changes in #3694 included a few parameters being passed to PaywallsTester that had the wrong name, this addresses it

@aboedo aboedo added the test Adding missing tests or correcting existing tests label Mar 6, 2024
@aboedo aboedo self-assigned this Mar 6, 2024
@aboedo aboedo requested a review from a team March 6, 2024 23:41
Comment on lines -34 to +40
onDismiss: {
print("Paywall dismissed")
restoreStarted: {
print("Restore started")
},
onRestoreCompleted: { _ in
restoreCompleted: { _ in
print("Restore completed")
},
onRestoreStarted: {
print("Restore started")
},
onRestoreFailure: {
restoreFailure: { _ in
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to re-order these too

@vegaro vegaro merged commit e6fe54e into main Mar 12, 2024
24 checks passed
@vegaro vegaro deleted the andy/fix_paywalls_tester branch March 12, 2024 15:57
This was referenced Mar 13, 2024
vegaro pushed a commit that referenced this pull request Mar 13, 2024
**This is an automatic release.**

### RevenueCatUI
* Add `PaywallView.onRequestedDismissal` modifier and option to pass
`dismissRequestedHandler` to `PaywallViewController` (#3738) via Cesar
de la Vega (@vegaro)
### Bugfixes
* [EXTERNAL] Fix Typos in ReceiptStrings.swift (#3756) via @nickkohrn
(#3760) via Cesar de la Vega (@vegaro)
### Other Changes
* Pin xcbeautify version for xcode 14 tests (#3759) via Cesar de la Vega
(@vegaro)
* PaywallsTester: fix compilation (#3753) via Andy Boedo (@aboedo)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Adding missing tests or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants