[EXTERNAL] Fix Typos in ReceiptStrings.swift (#3756) via @nickkohrn #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for contributing to Purchases! Before pressing the "Create Pull Request" button, please provide the following: --> ### Checklist - [x] If applicable, unit tests - [ ] If applicable, create follow-up issues for `purchases-android` and hybrids ### Motivation I wanted to fix simple typos in log messages to provide a slightly better developer experience. ### Description The changes include a fix for a typo in a string and a typo in an enumeration case declaration. Unit tests were not implemented for `ReceiptStrings.swift`, so I added unit tests to cover all `ReceiptStrings` members. ### Notes I looked for similar issues in the repositories for `purchases-android` and hybrids, but I did not find any.
tonidero
approved these changes
Mar 13, 2024
This was referenced Mar 13, 2024
vegaro
pushed a commit
that referenced
this pull request
Mar 13, 2024
**This is an automatic release.** ### RevenueCatUI * Add `PaywallView.onRequestedDismissal` modifier and option to pass `dismissRequestedHandler` to `PaywallViewController` (#3738) via Cesar de la Vega (@vegaro) ### Bugfixes * [EXTERNAL] Fix Typos in ReceiptStrings.swift (#3756) via @nickkohrn (#3760) via Cesar de la Vega (@vegaro) ### Other Changes * Pin xcbeautify version for xcode 14 tests (#3759) via Cesar de la Vega (@vegaro) * PaywallsTester: fix compilation (#3753) via Andy Boedo (@aboedo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging #3756 into
main