Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics event for Customer Info verification #3823

Merged

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Apr 19, 2024

Track CustomerInfo verification results

@vegaro vegaro changed the title Add diagnostics event for verification errors Add diagnostics event for Customer Info verification Apr 22, 2024
@vegaro vegaro added the refactor A code change that neither fixes a bug nor adds a feature label Apr 22, 2024
@vegaro vegaro marked this pull request as ready for review April 22, 2024 15:39
@vegaro vegaro requested a review from a team April 22, 2024 15:40
Copy link
Member

@jamesrb1 jamesrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if my approval should yet mean safe to merge, that is up to you!

Sources/Diagnostics/DiagnosticsTracker.swift Show resolved Hide resolved
Sources/Identity/CustomerInfoManager.swift Outdated Show resolved Hide resolved
Sources/Identity/CustomerInfoManager.swift Outdated Show resolved Hide resolved
Sources/Purchasing/Purchases/Purchases.swift Outdated Show resolved Hide resolved
@RevenueCat-Danger-Bot
Copy link

RevenueCat-Danger-Bot commented Apr 25, 2024

1 Message
📖 Size increase: 7.47 KB

Generated by 🚫 Danger

@vegaro vegaro force-pushed the sdk-2926-ios-add-diagnostics-event-for-verification-errors branch from b16d4a7 to fae4542 Compare April 25, 2024 12:04
@vegaro
Copy link
Contributor Author

vegaro commented Apr 25, 2024

I think it counts as valid @jamesrb1 ! Thanks for the review. This will not yet be enabled so it's safe to merge

@vegaro vegaro enabled auto-merge (squash) April 25, 2024 12:09
@vegaro vegaro force-pushed the sdk-2926-ios-add-diagnostics-event-for-verification-errors branch from 6e86067 to 6b0fa84 Compare April 25, 2024 20:37
@vegaro vegaro merged commit 5e0bc32 into main Apr 25, 2024
24 checks passed
@vegaro vegaro deleted the sdk-2926-ios-add-diagnostics-event-for-verification-errors branch April 25, 2024 21:03
vegaro pushed a commit that referenced this pull request Apr 30, 2024
**This is an automatic release.**

### Bugfixes
* `Paywalls`: Update Norwegian "restore" localization (#3844) via Josh
Holtz (@joshdholtz)
### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `f88dcd4` to `dd5e21f`
(#3839) via dependabot[bot] (@dependabot[bot])
* Update Package.resolved (#3822) via Cesar de la Vega (@vegaro)
* Bump fastlane-plugin-revenuecat_internal from `1e62420` to `f88dcd4`
(#3831) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Add diagnostics event for Customer Info verification (#3823) via Cesar
de la Vega (@vegaro)
* Fix backend integration test (#3847) via Josh Holtz (@joshdholtz)
* Push to SPM after release has been made (#3834) via James Borthwick
(@jamesrb1)
* Add note to readme about new spm repo (#3828) via James Borthwick
(@jamesrb1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants