-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics event for Customer Info verification #3823
Merged
vegaro
merged 10 commits into
main
from
sdk-2926-ios-add-diagnostics-event-for-verification-errors
Apr 25, 2024
Merged
Add diagnostics event for Customer Info verification #3823
vegaro
merged 10 commits into
main
from
sdk-2926-ios-add-diagnostics-event-for-verification-errors
Apr 25, 2024
+246
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vegaro
changed the title
Add diagnostics event for verification errors
Add diagnostics event for Customer Info verification
Apr 22, 2024
vegaro
added
the
refactor
A code change that neither fixes a bug nor adds a feature
label
Apr 22, 2024
jamesrb1
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if my approval should yet mean safe to merge, that is up to you!
Generated by 🚫 Danger |
vegaro
force-pushed
the
sdk-2926-ios-add-diagnostics-event-for-verification-errors
branch
from
April 25, 2024 12:04
b16d4a7
to
fae4542
Compare
I think it counts as valid @jamesrb1 ! Thanks for the review. This will not yet be enabled so it's safe to merge |
vegaro
force-pushed
the
sdk-2926-ios-add-diagnostics-event-for-verification-errors
branch
from
April 25, 2024 20:37
6e86067
to
6b0fa84
Compare
vegaro
deleted the
sdk-2926-ios-add-diagnostics-event-for-verification-errors
branch
April 25, 2024 21:03
vegaro
pushed a commit
that referenced
this pull request
Apr 30, 2024
**This is an automatic release.** ### Bugfixes * `Paywalls`: Update Norwegian "restore" localization (#3844) via Josh Holtz (@joshdholtz) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `f88dcd4` to `dd5e21f` (#3839) via dependabot[bot] (@dependabot[bot]) * Update Package.resolved (#3822) via Cesar de la Vega (@vegaro) * Bump fastlane-plugin-revenuecat_internal from `1e62420` to `f88dcd4` (#3831) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Add diagnostics event for Customer Info verification (#3823) via Cesar de la Vega (@vegaro) * Fix backend integration test (#3847) via Josh Holtz (@joshdholtz) * Push to SPM after release has been made (#3834) via James Borthwick (@jamesrb1) * Add note to readme about new spm repo (#3828) via James Borthwick (@jamesrb1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track CustomerInfo verification results