Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: improved ErrorCode.storeProblemError to indicate potential cancellation #943

Merged
merged 1 commit into from Nov 15, 2021
Merged

macOS: improved ErrorCode.storeProblemError to indicate potential cancellation #943

merged 1 commit into from Nov 15, 2021

Conversation

NachoSoto
Copy link
Contributor

Workaround for #370.

@NachoSoto NachoSoto mentioned this pull request Nov 15, 2021
Closed
taquitos
taquitos approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@taquitos taquitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥅 ⚽ 💨 🐐

@NachoSoto NachoSoto merged commit 6ef1744 into RevenueCat:main Nov 15, 2021
@NachoSoto NachoSoto deleted the mac-os-cancelled-purchase-error branch November 15, 2021 21:37
@revenuecat-ops revenuecat-ops mentioned this pull request Nov 18, 2021
Merged
NachoSoto added a commit that referenced this pull request Dec 14, 2021
@NachoSoto
PurchasesOrchestrator: wrapping StoreKitError in our own error
e21f117 
This allows us to handle unknown errors, like reported we did in #943, and provide a better user experience.
I filed FB9808927 for this issue in StoreKit 2. Unfortunately we can't do the same we did in #965.
@NachoSoto NachoSoto mentioned this pull request Dec 14, 2021
Merged
NachoSoto added a commit that referenced this pull request Dec 15, 2021
@NachoSoto
PurchasesOrchestrator: wrapping StoreKitError in our own error
9fa40ec 
This allows us to handle unknown errors, like reported we did in #943, and provide a better user experience.
I filed FB9808927 for this issue in StoreKit 2. Unfortunately we can't do the same we did in #965.
NachoSoto added a commit that referenced this pull request Dec 16, 2021
@NachoSoto
PurchasesOrchestrator: wrapping StoreKitError in our own error (#1084)
66d015d 
This allows us to handle unknown errors, like reported we did in #943, and provide a better user experience.
I filed FB9808927 for this issue in StoreKit 2. Unfortunately we can't do the same we did in #965 because the `StoreKitError` has no underlying information.

### Before:
<img width="372" alt="Screen Shot 2021-12-14 at 12 25 14" src="https://user-images.githubusercontent.com/685609/146079013-9073a170-d189-4cfc-b05a-d6c7e344b7cd.png">

### After:
<img width="372" alt="Screen Shot 2021-12-14 at 12 21 37" src="https://user-images.githubusercontent.com/685609/146078999-ce9387a8-f26f-43d2-b41c-f477de42a568.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taquitos taquitos taquitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NachoSoto @taquitos