Detect ErrorCode.productAlreadyPurchasedError when SKError.unknown is actually cased by it #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actually caused by it Fixes RevenueCat#392.
taquitos
approved these changes
Nov 18, 2021
| @@ -2112,6 +2112,45 @@ class PurchasesTests: XCTestCase { | |||
| expect(receivedUserCancelled).toEventually(beFalse()) | |||
| } | |||
|
|
|||
| func testUnknownErrorCurrentlySubscribedIsParsedCorrectly() { | |||
There was a problem hiding this comment.
Yessss tests are the bests
aboedo
approved these changes
Nov 18, 2021
Comment on lines
+243
to
+248
| case .unknown: | ||
| if let error = self.userInfo[NSUnderlyingErrorKey] as? NSError { | ||
| switch (error.domain, error.code) { | ||
| case ("ASDServerErrorDomain", 3532): // "You’re currently subscribed to this" | ||
| // See https://github.com/RevenueCat/purchases-ios/issues/392 | ||
| return .productAlreadyPurchasedError |
Merged
NachoSoto
added a commit
that referenced
this pull request
Dec 16, 2021
This allows us to handle unknown errors, like reported we did in #943, and provide a better user experience. I filed FB9808927 for this issue in StoreKit 2. Unfortunately we can't do the same we did in #965 because the `StoreKitError` has no underlying information. ### Before: <img width="372" alt="Screen Shot 2021-12-14 at 12 25 14" src="https://user-images.githubusercontent.com/685609/146079013-9073a170-d189-4cfc-b05a-d6c7e344b7cd.png"> ### After: <img width="372" alt="Screen Shot 2021-12-14 at 12 21 37" src="https://user-images.githubusercontent.com/685609/146078999-ce9387a8-f26f-43d2-b41c-f477de42a568.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392.
As per the conversation in that issue, this introspects and checks for the undocumented error domain and code.