Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge buttons are missing for issues that don't require a response #93

Closed
jdm opened this issue May 4, 2015 · 6 comments
Closed
Labels

Comments

@jdm
Copy link

jdm commented May 4, 2015

When I have left an issue that must be addressed but is later addressed by changes elsewhere, it's frustrating to require the PR author to write a comment just so I can mark it resolved.

@pkaminski
Copy link
Member

When you're the only commenter on a discussion, you should be able to resolve it outright with the round checkmark button in the lower-right corner:
image
Do you get this button? If not, can you point me to the discussion you'd like to close so I can investigate? Thanks.

@jdm
Copy link
Author

jdm commented May 4, 2015

All of my open issues on the left side of https://reviewable.io/reviews/servo/servo/5800 are missing Done buttons.

@pkaminski
Copy link
Member

You're not looking for a Done button, but the round checkmark button in the lower-right corner of a thread. Can you share a screenshot of what one of those comments looks like for you? (Different users will see a different UI, depending on the authorship of the PR and the comment.)

@jdm
Copy link
Author

jdm commented May 4, 2015

I've used the checkmark button before, and it's not there. Screenshot coming up.

@jdm
Copy link
Author

jdm commented May 4, 2015

screen shot 2015-05-04 at 3 20 08 pm

@pkaminski
Copy link
Member

Ah, OK. In this case, since another user is involved in the discussion thread, there's no way to resolve it without their acknowledgement. This is on purpose, so that the discussion doesn't "disappear" (get resolved) without the other person having seen your comment. There's no need for them to write a comment, though: they can just acknowledge and the discussion will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants