-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acknowledge buttons are missing for issues that don't require a response #93
Comments
All of my open issues on the left side of https://reviewable.io/reviews/servo/servo/5800 are missing |
You're not looking for a |
I've used the checkmark button before, and it's not there. Screenshot coming up. |
Ah, OK. In this case, since another user is involved in the discussion thread, there's no way to resolve it without their acknowledgement. This is on purpose, so that the discussion doesn't "disappear" (get resolved) without the other person having seen your comment. There's no need for them to write a comment, though: they can just acknowledge and the discussion will be closed. |
When I have left an issue that must be addressed but is later addressed by changes elsewhere, it's frustrating to require the PR author to write a comment just so I can mark it resolved.
The text was updated successfully, but these errors were encountered: