New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monster Spawners #319

Merged
merged 11 commits into from Jul 8, 2018

Conversation

Projects
None yet
2 participants
@95CivicSi
Collaborator

95CivicSi commented Jul 7, 2018

  • This PR actually submits something - don't use this system as a messaging service!
  • This PR isn't duplicated - you can check if it is by scanning the small list - link is on the navigation bar for this repository.
  • This PR includes appropriate markdown for sections - e.g. code blocks for suggested code.
  • This PR description and comments in code is understandable - feel free to use your native language to write if you are not comfortable with English.
  • This PR has a single branch for itself in your fork - don't just commit to the master branch of your repository!
  • This PR has comments written in clear English - please don't write unreadable comments just for your eyes.

Pull Request description

This will fix several existing bugs with Monser Spawners where the mob being spawned doesn't show up inside the Monster Spawner and server restarts can cause the Spawner to stop working.

Changed Branch

Master

Optional information

Details of what was changed are included in each commit message. Most notable are:

  • Addition of a new block class: MonsterSpawnerPEX
  • Refactor of Spawner to MobSpawner
  • Update MobSpawner::setSpawnEntityType

The biggest complication here was that the game client displays the mob inside the Monster Spawner based on the NBT of the MobSpawner tile. Because the MobSpawner class was previously called Spawner, game clients didn't recognize the NBT Tag id as a spawner.

@95CivicSi 95CivicSi merged commit c804b85 into master Jul 8, 2018

2 checks passed

poggit-ci/PureEntitiesX Created Dev build #258 (&45413): Lint passed
Details
poggit-ci/pureentitiesx Created PR build #87 (&45414): Lint passed
Details
@SamyR0

This comment has been minimized.

SamyR0 commented Aug 1, 2018

gj

@95CivicSi 95CivicSi deleted the Fix_Mob_Spawners branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment