Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SharpZipLib to 1.4.1 and fix the resulting save corruption #3925

Closed
hhyyrylainen opened this issue Dec 9, 2022 · 2 comments
Closed

Update SharpZipLib to 1.4.1 and fix the resulting save corruption #3925

hhyyrylainen opened this issue Dec 9, 2022 · 2 comments
Labels
C# dependencies intermediate programming
Projects
Thrive Planning

Comments

@hhyyrylainen
Copy link
Member

I tested updating to that version and it results in writing and reading saves to become corrupt with invalid tar header error. Either the library has a regression or some API changed in it that requires changes to our code.
@hhyyrylainen hhyyrylainen added this to Backburner in Thrive Planning via automation Dec 9, 2022
hhyyrylainen added a commit that referenced this issue Dec 9, 2022
@hhyyrylainen
Revert update to SharpZipLib as it caused broken saves
7e83883 
follow up issue: #3925
hhyyrylainen added a commit that referenced this issue Dec 9, 2022
@hhyyrylainen
Final changes for release 0.6.0 (#3924)
a28bf33 
* Updated submodule

* Updated translation progress

* Updated credits

* Bump version to 0.6.0

* Updated the JSON and zip library versions

* Update submodule again

* Revert update to SharpZipLib as it caused broken saves

follow up issue: #3925

* Explain the multiply by 2 in the compound venting threshold
@hhyyrylainen
Copy link
Member Author

There's now 1.4.2 version available.

@hhyyrylainen
Copy link
Member Author

This is superceded by: #4156

Thrive Planning automation moved this from Backburner to Done May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C# dependencies intermediate programming
Projects
Thrive Planning
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hhyyrylainen