Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingested matter bar / engulfed object can get stuck being engulfed with 0 size remaining #4794

Open
hhyyrylainen opened this issue Jan 10, 2024 · 7 comments

Comments

@hhyyrylainen
Copy link
Member

hhyyrylainen commented Jan 10, 2024

Looks like the ingested matter bar showing 0 (or a low value) is back with an engulfable being stuck not progressing anymore. For ECS I had to remove one NaN compound clamping due to multithreading in the digestion processing, but I was hoping everything else would compensate for that (there's a separate issue about checking that: #4700). Though I'm not even fully sure what is the root cause here, but that's at least somewhere to start. I already tried to add various safety checks in the code but that didn't solve the issue: #4793

Here's a save that shows the stuck bar: https://dev.revolutionarygamesstudio.com/files/Public/Testing%20Resources/Saves/toxin_digest_bug.thrivesave

@hhyyrylainen
Copy link
Member Author

Maybe this or another issue also can make the ingested matter get stuck at a different value (0.1).

A save showing this problem would also be likely useful.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.6 milestone Feb 25, 2024
@hhyyrylainen
Copy link
Member Author

Potential steps to reproduce the issue

I engulfed some cell, waited until ingested matter bar get's low (0.3, for example) and then enter editor (I entered via P button cheat if it matters)

But I couldn't get the bug to appear like that, this is the cell build I had:

2024-02-25_13 21 10 6749

@CI09
Copy link
Contributor

CI09 commented Feb 25, 2024

Save link:
https://dev.revolutionarygamesstudio.com/files/Public/Testing%20Resources/Saves/Engulfing.thrivesave

@CI09
Copy link
Contributor

CI09 commented Feb 27, 2024

Does that happen only when leaving editor?

@CI09
Copy link
Contributor

CI09 commented Feb 27, 2024

Also it can be fixed by making digested enulfable disappear not when 100% digested but a bit ealier by tweaking one constant. There will likely be side effects though

@hhyyrylainen
Copy link
Member Author

That could explain that there is some bug related to the fully digested thing destroying and removal from the list of engulfed things. There's separate code for handling something being fully digested and needing to be removed. So that could be a pretty good clue to where to look in the code for a bug.

@hhyyrylainen
Copy link
Member Author

A potentially related new issue: #5013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Thrive Planning
  
High priority bugs / issues
Development

No branches or pull requests

2 participants