Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various safety checks for negative engulfed compound amounts #4793

Merged
merged 4 commits into from
Jan 15, 2024

Conversation

hhyyrylainen
Copy link
Member

@hhyyrylainen hhyyrylainen commented Jan 10, 2024

Brief Description of What This PR Does

Hopefully this fixes an actual bug. If nothing else this should at least make it so

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.5 milestone Jan 10, 2024
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Jan 10, 2024
Copy link

@ARecurringProblem ARecurringProblem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still the issue of the ingested matter sticking around forever, but this solves the problem of forever taking damage from ingesting toxins which fixes a major gameplay issue.

@hhyyrylainen
Copy link
Member Author

I opened a separate issue about the ingested matter bar getting stuck on again as I couldn't find a fix for it: #4794

@hhyyrylainen hhyyrylainen merged commit 62fe220 into master Jan 15, 2024
4 checks passed
Thrive Planning automation moved this from In progress to Done Jan 15, 2024
@hhyyrylainen hhyyrylainen deleted the engulf_negative_compound_clamping branch January 15, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants