Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New intro video #3847

Merged
merged 1 commit into from
Nov 4, 2022
Merged

New intro video #3847

merged 1 commit into from
Nov 4, 2022

Conversation

Oliveriver
Copy link
Contributor

@Oliveriver Oliveriver commented Nov 4, 2022

Brief Description of What This PR Does

Amazing new intro video courtesy of QuantumCrab.

Related Issues

N/A

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@buckly90
Copy link
Member

buckly90 commented Nov 4, 2022

Seems to work perfectly, consistently, and with no errors that I can identify.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.0 milestone Nov 4, 2022
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Nov 4, 2022
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks to be fine, though the video is 24 FPS instead of 30, but that doesn't seem that visible of a difference so I'll just merge this right away (replacing the file anyway in the future keeps both in git LFS)

@hhyyrylainen hhyyrylainen merged commit 3a53a65 into master Nov 4, 2022
@hhyyrylainen hhyyrylainen deleted the new_intro branch November 4, 2022 07:12
Thrive Planning automation moved this from In progress to Done Nov 4, 2022
adQuid pushed a commit to adQuid/Thrive that referenced this pull request Nov 5, 2022
adQuid added a commit to adQuid/Thrive that referenced this pull request Nov 5, 2022
Co-authored-by: Oliveriver <oliveriver1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants