Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinite compound venting due to having compounds over capacity in the cell #3926

Merged
merged 3 commits into from
Dec 9, 2022

Conversation

Oliveriver
Copy link
Contributor

@Oliveriver Oliveriver commented Dec 9, 2022

Brief Description of What This PR Does

Prevents taking negative compounds from the cloud system, which was causing another infinite compound venting glitch. Also fixes compound venting to seemingly prevent a cell ending up with more compounds than it can contain.

Related Issues

N/A

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@revolutionary-bot
Copy link

We are currently in feature freeze until the next release.
If your PR is not just a simple fix, then it may take until the release to get reviewed and merged.

@hhyyrylainen hhyyrylainen requested review from a team December 9, 2022 18:18
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Dec 9, 2022
@hhyyrylainen hhyyrylainen added this to the Release 0.6.0 milestone Dec 9, 2022
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine by me to be included in the release.

@hhyyrylainen hhyyrylainen merged commit baa0e97 into master Dec 9, 2022
@hhyyrylainen hhyyrylainen deleted the fix_infinite_compounds_again branch December 9, 2022 19:54
Thrive Planning automation moved this from In progress to Done Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants