Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ComputeRandomRadianRotation function and '%' suffix for compounds in patch details #3931

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

ender-titan1
Copy link
Member

@ender-titan1 ender-titan1 commented Dec 11, 2022

Brief Description of What This PR Does

Removes the unused ComputeRandomRadianRotation function from SpawnSystem.cs and also removes the '%' format from compounds in the patch details menu.

Related Issues

Closes #3883
Closes #3909

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (In progress - all I have at the moment is GitPod.)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen requested review from a team December 11, 2022 09:37
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Dec 11, 2022
@hhyyrylainen hhyyrylainen added this to the Release 0.6.1 milestone Dec 11, 2022
@hhyyrylainen
Copy link
Member

You should leave the default PR checklist intact so that we can track what has been checked for the PR.

@ender-titan1
Copy link
Member Author

Ok, got it

@hhyyrylainen
Copy link
Member

The Jetbrains fail is that it wants you to put CurrentCulture as parameter to the ToString calls.
Also the change to the Godot project file should be reverted because it's very suspicious to me.

@hhyyrylainen
Copy link
Member

The code change looks fine to me, just need someone to playtest this next.

Copy link
Member

@athariqk athariqk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@hhyyrylainen hhyyrylainen merged commit 40b61bd into Revolutionary-Games:master Dec 13, 2022
Thrive Planning automation moved this from In progress to Done Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
3 participants