Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved a few more platform handling methods to the common module #3940

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

hhyyrylainen
Copy link
Member

from the scripts in this repo

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.1 milestone Dec 13, 2022
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Dec 13, 2022
@hhyyrylainen hhyyrylainen merged commit fe14c67 into master Dec 15, 2022
@hhyyrylainen hhyyrylainen deleted the move_some_package_to_common branch December 15, 2022 07:12
Thrive Planning automation moved this from In progress to Done Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant