Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger MainMenu.OnEnteringGame in autoevo explore tool and thriveopedia museum #4166

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

athariqk
Copy link
Member

@athariqk athariqk commented Feb 25, 2023

Brief Description of What This PR Does

Closes #4112.

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@athariqk athariqk added this to the Release 0.6.2 milestone Feb 25, 2023
@athariqk athariqk requested review from a team February 25, 2023 08:26
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Feb 25, 2023
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible. I won't test this for now but rely on natural testing happening on other stuff before the release.

@hhyyrylainen hhyyrylainen merged commit ec28a33 into master Feb 27, 2023
@hhyyrylainen hhyyrylainen deleted the 4112_on_entering_game branch February 27, 2023 07:57
Thrive Planning automation moved this from In progress to Done Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

MainMenu.OnEnteringGame needs to be triggered by auto-evo exploring tool and Thriveopedia
2 participants