Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect data in multicellular cell indexes #4641

Merged
merged 1 commit into from Dec 12, 2023

Conversation

hhyyrylainen
Copy link
Member

which caused a crash when regrowing and then despawning due to incorrect parent indexes for colony cells

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

which caused a crash when regrowing and then despawning due to incorrect parent indexes for colony cells
@hhyyrylainen hhyyrylainen added this to the Release 0.6.4.1 milestone Dec 11, 2023
@hhyyrylainen hhyyrylainen added this to In progress in Thrive Planning via automation Dec 11, 2023
@buckly90
Copy link
Member

How can I test this PR? Not sure how to reproduce the bug.

@hhyyrylainen
Copy link
Member Author

I tested this by loading up a previous save where I got this crash within 5-10 minutes, suiciding, and then waiting 30 minutes to see if the game crashed.

@hhyyrylainen hhyyrylainen merged commit b731c4d into master Dec 12, 2023
4 checks passed
Thrive Planning automation moved this from In progress to Done Dec 12, 2023
@hhyyrylainen hhyyrylainen deleted the colony_regrow_data_fix branch December 12, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants