Add Fog Of War #4670
Add Fog Of War #4670
Conversation
|
The previous commit is supposed to make connections to unknown regions look nicer, which was what held up the development of my previous PR. This time, I did not bother changing the way connections are rendered, instead just centering a single node in the region. This yields ok results, albeit still a bit disconnected from the rest of the map. I think this is fine for now, and trying to make it look nicer should be done by someone more experienced with the patch map code, and probably be a separate issue. I believe the results of this are good enough for fog-of-war itself. |
|
This is now ready for review |
Minimum FogOfWar Implementation Fix some node rendering issues Add Ignored/Disable mode Hide PatchDetailsPanel of unknown patches Fix formatting Add basic PatchMapDrawer node hiding Fog of War now ignored in certain contexts Add Reveal All Patches Cheat
To do so, draw calls have been replaced by Line2d objects Fix overlapping connection lines and borders Censor undiscovered patch names in Timeline and Report Make sure unknown regions do not have a border Change the way unknown regions are drawn Update Translations Update translations again and fix some other things Formatting Delete argument I forgot to delete Delete using I forgot to delete Update cheat button look
And also change the game version to 0.6.5.0 Undo some changes Add comments
Avoid unnecessary object allocations when getting names of hidden patches
for the fog of war
hhyyrylainen
force-pushed
the
fog-of-war
branch
from
c8c90cb
to
bb9142e
Compare
for the fog of war
There was a problem hiding this comment.
I've fixed all of the slight code issues I saw and fixed up comment typos etc. I've also tested this quickly for each fog of war mode and also loading one earlier save. I think this is now good to go by me, but I'll wait a bit until merging to give others time to double check my changes that I didn't accidentally break anything.
|
I think you undid my manual squashing of this PR... I think I'll be able to fix it tomorrow by cherry picking the following commit: Edit: for future reference you need to force pull first a branch if it has been remotely squashed before resuming working on it locally. |
|
Sorry, I'll keep this in mind for future PRs |
hhyyrylainen
force-pushed
the
fog-of-war
branch
from
4b2490b
to
0f97de8
Compare
|
Alright, that was much easier than expected. Hopefully you didn't make any other changes than that one commit about where the region link build was. This should be fine to merge now with the cleaned up history. |
|
Seems like auto-evo exploring tool has broken map for all worlds after the first. I'll open an issue about that as a follow up to get this PR merged to no longer have to fix this branch: #4731 |
Brief Description of What This PR Does
This PR is the second version of my implementation of Fog Of War to the patch map. This is a much nicer and more elegant solution to Fog Of War, with most of the code governing patch visibility contained in
PatchMapandPatchitself.Link to my previous PR (Just in case): #4462
Feature Checklist:
Related Issues
Closes #3602
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.