Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed GetMicrobeFromSubShape max index off by one crash #4779

Merged
merged 1 commit into from Jan 9, 2024
Merged

Fixed GetMicrobeFromSubShape max index off by one crash #4779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/microbe_stage/components/MicrobeColony.cs
View file
Open in desktop
Expand Up @@ -319,14 +319,16 @@ public static void PerformForOtherColonyMembersThanLeader(this ref MicrobeColony
throw new InvalidOperationException("Bad calculated microbe index");
#endif

var members = colony.ColonyMembers;

// In case the physics data is not yet up to date compared to the colony members, skip
if (microbeIndex > colony.ColonyMembers.Length)
if (microbeIndex >= members.Length)
{
microbe = default;
return false;
}

microbe = colony.ColonyMembers[microbeIndex];
microbe = members[microbeIndex];
return true;
}

Expand Down