New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3 variables trying to access another scene's nodes #4954
Conversation
and added a replacement function. Also disconnected unnecessary signals.
429c508
to
2693015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is starting to remove a good number of variables but I think there's still some more stuff that can be moved to the editor entry button scene to avoid needing to specify those in the HUDs.
2f2b2c4
to
a4600de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably fine now, I assume your testing hasn't brought up any more problems with this.
and added a replacement function. Also disconnected unnecessary signals.
Brief Description of What This PR Does
Related Issues
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.