Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3 variables trying to access another scene's nodes #4954

Merged
merged 5 commits into from Mar 22, 2024

Conversation

CI09
Copy link
Contributor

@CI09 CI09 commented Mar 19, 2024

and added a replacement function. Also disconnected unnecessary signals.

Brief Description of What This PR Does

Related Issues

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

and added a replacement function. Also disconnected unnecessary signals.
@CI09 CI09 added the review label Mar 19, 2024
@CI09 CI09 requested review from a team March 19, 2024 20:51
@CI09 CI09 added this to the Release 0.6.6 milestone Mar 19, 2024
@CI09 CI09 requested a review from hhyyrylainen March 20, 2024 16:41
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is starting to remove a good number of variables but I think there's still some more stuff that can be moved to the editor entry button scene to avoid needing to specify those in the HUDs.

src/general/base_stage/CreatureStageHUDBase.cs Outdated Show resolved Hide resolved
src/microbe_stage/gui/EditorEntryButton.cs Show resolved Hide resolved
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably fine now, I assume your testing hasn't brought up any more problems with this.

@hhyyrylainen hhyyrylainen merged commit 8f70a5d into master Mar 22, 2024
4 checks passed
@hhyyrylainen hhyyrylainen deleted the remove_hud_variables branch March 22, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants