Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for texture loading (#639) #741

Merged
merged 10 commits into from Feb 24, 2019
Merged

Fix for texture loading (#639) #741

merged 10 commits into from Feb 24, 2019

Conversation

hhyyrylainen
Copy link
Member

@hhyyrylainen hhyyrylainen commented Feb 18, 2019

In my tests this fixes #639 (I tested for 50 minutes, before the issue popped up in a few minutes).

The issue was running out of open files. In the future we need to do something about our audio library, which isn't very good.

… because in the createbackground we only checked one of the backgrounds before editing it."

This reverts commit c01247b.
…ult it always uses the same texture (ocean, we can change that later very easily so i can fix that), but at least it seems to have stopped the banana background from happening."

This reverts commit 3223dcf.
The bandaids should now all be gone
@hhyyrylainen hhyyrylainen added this to the Release 0.4.1 milestone Feb 18, 2019
@hhyyrylainen hhyyrylainen self-assigned this Feb 18, 2019
@hhyyrylainen hhyyrylainen marked this pull request as ready for review February 18, 2019 19:14
@hhyyrylainen
Copy link
Member Author

This now should include the cAudio fix by @crodnu to make it open less files, which hopefully will fix this for everyone.

@hhyyrylainen hhyyrylainen merged commit 756b3e8 into master Feb 24, 2019
@hhyyrylainen hhyyrylainen deleted the 639_banana_fix branch September 6, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant