This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
Update index.html #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change save function
Reza-Rajabi
suggested changes
Sep 22, 2019
| @@ -122,7 +122,7 @@ <h4>Shortcut: ctrl + x to save.</h4> | |||
| }); | |||
|
|
|||
| function save() { | |||
| let data = document.querySelector('#note').innerHTML.toString().trim(); | |||
| let data = document.querySelector('#note').innerHTML; | |||
There was a problem hiding this comment.
Thank you very much for your time and your effort for fixing this issue.
I have been looking at other note-taking apps for this Release1 and I noticed the problem with this part of code is that it captures and stores all HTML tags as well. So innerHTML needs to be changed to innerText.
Other than that, when the captured text gets fixed, it still is not working on the deployed version.
Some other codes I have been looking at had their functions inside the filer write/read method. That might solve this problem. I am not sure, but we can try.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I just changed little bit of code and it works!
will work on clear function too!