Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone set to long button press in latest firmware doesnt seem to clone anymore #43

Open
quentynt opened this issue Sep 19, 2020 · 8 comments

Comments

@quentynt
Copy link

hi in latest firmware pulled today setting long button press to clone doesnt seem to clone mifare classics UID's any more

going back a few versions and it seems to work as expected

@nieldk
Copy link

nieldk commented Sep 19, 2020

I will have a look. PR #24 is where I added long-press functionality. Hopefully this weekend :)

Had a look, not my PR that broke, but there are only so many changes since that. So, still looking for what broke long press.

@qqice
Copy link

qqice commented Sep 20, 2020

hi I also encountered this issue. Actually, it's nothing to do with long button press function, but clone function itself.
I noticed that since "CLONE_MFU" function was add, the "clone" function, along with "CLONE_MFU" function, fails to function properly.
So I flashed the build 152dc71 to get it back to functioning.

@nieldk
Copy link

nieldk commented Oct 14, 2020

The problem is that Latest pull request extends the FW above allowed size. Resulting in config getting wiped.
Added pull request #46 (comment) to reduce the size of the Firmware, using LTO.
My tests seems to fix this issue.

@zviratko
Copy link

I have the same issue on latest firmwares, are you sure it is fixed?

@quentynt
Copy link
Author

quentynt commented Sep 22, 2021 via email

@zviratko
Copy link

Hmm, doesn't look like it's commented out. Where did you see it?

@xeonxu
Copy link

xeonxu commented Nov 30, 2021

Seems this c5b0798 commit cause the issue.

@d4g
Copy link

d4g commented Jan 22, 2024

Has this ever been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants