Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iClass support #91

Merged
merged 1 commit into from
Jun 28, 2022
Merged

iClass support #91

merged 1 commit into from
Jun 28, 2022

Conversation

nvx
Copy link

@nvx nvx commented Jun 28, 2022

Requires enabling in Makefile and disabling other options to fit in program space below 64k. An example Makefile with iClass support enabled that fits is at https://github.com/nvx/ChameleonMini/blob/proxgrind/Firmware/Chameleon-Mini/Makefile

Note that apps don't seem to support this new unknown type very well (the Android app just flat out refuses to load the file, while ChameleonMini-rebootedGUI defaults to MIFARE) and will require updating. I've updated the latter here nvx/ChameleonMini-rebootedGUI@38af56d (unknown file types now leave the type unchanged by default too which is handy for adding new formats generally), but it doesn't look like the Android app is open source though so not sure how one would go about getting that updated.

Requires enabling in Makefile and disabling other options to fit in program space below 64k
@nvx
Copy link
Author

nvx commented Jun 28, 2022

As an aside, when building the firmware ensure the program size reported at the end of the build is below 65535. While this is only ~50% of the space, it looks like the remaining space is reserved for holding card data so bad things happen if the code goes above that point. I'm not sure how much of the space above 64k is being used and if it could be tweaked to be slightly smaller to allow more options to be enabled at once.

Whatever the threshold has to be, it would also be nice if the build process detected overrunning the program space automatically to fail the build. I'm sure it'd save a lot of confusion with newcomers.

@iceman1001 iceman1001 merged commit 1132f71 into RfidResearchGroup:proxgrind Jun 28, 2022
@iceman1001
Copy link
Collaborator

Awesome contribution,
and yes, the build should preferably detect and warn when building a too large image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants