Memory leak #31
Merged
Memory leak #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejohnhoffer
commented
Mar 23, 2017
| @@ -153,7 +153,7 @@ def __init__(self): | |||
| # ALL THE DATABASE RUNTIME TERMS | |||
| self.DB = NamelessStruct( | |||
| TABLE = NamelessStruct( | |||
| LIST = _table_list, | |||
| LIST = _table_list[:], | |||
There was a problem hiding this comment.
We do not want to write this for each list in UtilityLayer/Keywords.py, since it will be very easy to forget. The dereferencing with [:] should instead happen in UtilityLayer/Structures.py, where it will only need to be written once in the class definition of NamelessStruct.
thejohnhoffer
commented
Mar 23, 2017
| # Begin making the list | ||
| all_list = _keywords.get('LIST',[]) | ||
| # Begin a new list of all keyword NAMES | ||
| all_list = _keywords.get('LIST',[])[:] |
There was a problem hiding this comment.
Start accumulating keyword names in a copy of the LIST keyword.
There was a problem hiding this comment.
good catch @jtriley @thejohnhoffer
thejohnhoffer
commented
Mar 23, 2017
| # Begin making the list | ||
| all_list = _keywords.get('LIST',[]) | ||
| # Begin a new list of all keyword NAMES | ||
| all_list = _keywords.get('LIST',[])[:] | ||
| # Add other keywords to list | ||
| for key in _keywords: | ||
| keyval = _keywords[key] | ||
| setattr(self,key,keyval) | ||
| # Put all lists into list |
There was a problem hiding this comment.
The few changes not shown above here just improve code legibility. They have no functional effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found and fixed memory leak at line 156 of UtilityLayer/Keywords.py due to passing list of database table
['neuron','synapse']by reference instead of by values.The reference to this list gets passed as the
LISTkeyword of theNamelessStructRUNTIME.DB.TABLE. The internals of theNamelessStructin Line 19 of UtilityLayer/Structures.py add each keyword argumentNAMEto theLISTkeyword before adding unique vaules forself.LIST.Although in
NamelessStructself.LISTcontains only unique values, the original reference passed as the keyword argumentLISTcontinues to accumulate values. This issue can be fixed by using python's[:]notation to create a copy of the list.