Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MC 1.8 features #18

Merged
merged 2 commits into from Oct 1, 2014
Merged

Added MC 1.8 features #18

merged 2 commits into from Oct 1, 2014

Conversation

ST-DDT
Copy link

@ST-DDT ST-DDT commented Sep 19, 2014

Added MC v1.8 features.

  • Books (pages only)
  • Inventory.getTitle() and createInventory()
  • Player.setPlayerListName()
  • Signs

@@ -766,10 +766,28 @@
* @param type The type of inventory to create.
* @param title The title of the inventory, to be displayed when it is viewed.
* @return The new inventory.
* @deprecated This method now uses {@link Message} to return the title. Use
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to return the title ?

@ST-DDT
Copy link
Author

ST-DDT commented Sep 30, 2014

@Ribesg Did you have time to review it?

@Ribesg
Copy link
Owner

Ribesg commented Oct 1, 2014

Not at all @ST-DDT, I'll just merge it and let others review it in the main one

Ribesg added a commit that referenced this pull request Oct 1, 2014
@Ribesg Ribesg merged commit 04b84b6 into Ribesg:BUKKIT-5245-v2 Oct 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants