Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to Stable Rust Version #523

Closed
2 tasks
M-Adoo opened this issue Feb 2, 2024 · 3 comments
Closed
2 tasks

Transition to Stable Rust Version #523

M-Adoo opened this issue Feb 2, 2024 · 3 comments
Assignees
Labels
ci good first issue Good for newcomers rust Pull requests that update Rust code
Milestone

Comments

@M-Adoo
Copy link
Collaborator

M-Adoo commented Feb 2, 2024

Over the past half year, we've eliminated many of the nightly features previously used in Ribir's development. As a result, we no longer need to rely on Rust's nightly version. It's time to transition to the stable version of Rust.

  • Remove all remaining nightly features
  • Update our Continuous Integration (CI) to use the stable version of Rust
    • Currently, we're using nightly-2023-10-15. Search for this throughout the project and replace it with the stable version.
@M-Adoo M-Adoo added good first issue Good for newcomers ci rust Pull requests that update Rust code labels Feb 2, 2024
@katyo
Copy link

katyo commented Feb 6, 2024

@M-Adoo It sounds really good for me. I hope to use ribir with stable rust in my projects soon.

@M-Adoo
Copy link
Collaborator Author

M-Adoo commented Feb 24, 2024

@katyo I'm sorry for the late reply. It's great to hear that you want to use this in your project. Moving to stable Rust shouldn't be too difficult. However, I'm currently working on tasks that will cause break changes, and I want to finish these first. If you're up for it, you could try it out and let me know if you run into any problems. I'm here to help, and please don't worry if you don't have the time.

@M-Adoo M-Adoo added this to the 0.3 milestone Feb 28, 2024
@M-Adoo M-Adoo self-assigned this Mar 22, 2024
@M-Adoo
Copy link
Collaborator Author

M-Adoo commented Mar 29, 2024

closed by #552

@M-Adoo M-Adoo closed this as completed Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci good first issue Good for newcomers rust Pull requests that update Rust code
Projects
None yet
Development

No branches or pull requests

2 participants