This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Change how start() works
#21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits change
start()a bit:Only start listening for events after start was called. This should help users not to forget to call it (eg. First dispatch flagged as
isInitial, even ifroadtrip.start()wasn't called #10), as leaving it out will cause some subtle bugs (eg. missing the first route's scroll position).Add a
dispatchoption, which doesn't dispatch the current routes' handlers.Related to the previous point. Useful for SSRed apps. Alternative for checking
isInitialon every route. On the name: I just saw it used on a few libraries before.Set
scrollRestorationtomanualby default.ps. Sorry for the dump! All these PRs are obviously debatable; just let me know if anything doesn't work for you. Hopefully we can get at least #20 merged, since we can't handle even SSRed 404s right now.