Don't ignore golint issues

RichardKnop · Feb 13, 2018 · f4acc4e · f4acc4e
1 parent 0805f59
commit f4acc4e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Makefile b/Makefile
@@ -12,8 +12,9 @@ lint:
 
 golint:
 	for pkg in ${PACKAGES}; do \
-		golint $$pkg; \
-	done;
+		golint -set_exit_status $$pkg || GOLINT_FAILED=1; \
+	done; \
+	[ -z "$$GOLINT_FAILED" ]
 
 test:
 	TEST_FAILED= ; \

diff --git a/v1/brokers/aws_sqs_export_test.go b/v1/brokers/aws_sqs_export_test.go
@@ -62,9 +62,9 @@ func (e *ErrorSQS) DeleteMessage(*sqs.DeleteMessageInput) (*sqs.DeleteMessageOut
 
 func init() {
 	redisURL := os.Getenv("REDIS_URL")
-	brokerUrl := "https://sqs.foo.amazonaws.com.cn"
+	brokerURL := "https://sqs.foo.amazonaws.com.cn"
 	TestConf = &config.Config{
-		Broker:        brokerUrl,
+		Broker:        brokerURL,
 		DefaultQueue:  "test_queue",
 		ResultBackend: redisURL,
 	}

diff --git a/v1/brokers/broker.go b/v1/brokers/broker.go
@@ -88,6 +88,7 @@ func (b *Broker) stopConsuming() {
 	b.stopChan <- 1
 }
 
+// GetRegisteredTaskNames returns registered tasks names
 func (b *Broker) GetRegisteredTaskNames() []string {
 	return b.registeredTaskNames
 }