-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameters position calculation #2905
base: master
Are you sure you want to change the base?
Fix parameters position calculation #2905
Conversation
I think this is a breaking change and cannot be merged - also tests are failing. |
@RicoSuter I don't think failed tests are related to PR changes. The error is about missed nuget packages. Probably we need to run checks for PR again. Please check your tests and CI. Yes, it's breaking changes, but without that fix |
@RicoSuter As I said tests failed not because of these changes. After merging latest changes from master (and CI run caused by that), everything passed. Please review and merge is possible or ask me for changes |
I'm very afraid to break many people as this might reorder parameters. |
#2891