Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] C-lightning: UpdateFeePolicy option doesn't show current fees #659

Closed
tukac opened this issue Apr 18, 2021 · 2 comments · Fixed by #665
Closed

[Bug] C-lightning: UpdateFeePolicy option doesn't show current fees #659

tukac opened this issue Apr 18, 2021 · 2 comments · Fixed by #665
Assignees
@ShahanaFarooqui
Labels
bug Something isn't working Core Lightning
Milestone
Release 0.10.2-beta

Comments

@tukac
Copy link

tukac commented Apr 18, 2021

To Reproduce
Steps to reproduce the behavior:

  1. Run c-lightning
  2. Go to Peers/Channels menu > Open Channels menu > Update Fee Policy option

Fees shown here are not current. Fees can be changed here correctly, change will be communicated to c-lightning correctly but change will not be shown correctly. This menu always displays default fees irregardless of what they actually are.

In order to see current fees:
lightning-cli listchannels <short channel ID>

Browser, RTL plugin nor c-lightning restart do not resolve this issue.

Your environment

  • Version of RTL 0.10.0 beta
  • Version of c-lightning 0.10.0-27
  • Browser & browser version Firefox 87.0
  • Operating system (uname -a on *Nix) Linux Mint

Additional context
LND shows fees correctly in this menu. This is only c-lightning bug.
@tukac tukac changed the title C-lightning: UpdateFeePolicy option doesn't show actual fees [Bug] C-lightning: UpdateFeePolicy option doesn't show actual fees Apr 18, 2021
@tukac tukac changed the title [Bug] C-lightning: UpdateFeePolicy option doesn't show actual fees [Bug] C-lightning: UpdateFeePolicy option doesn't show current fees Apr 18, 2021
@tukac
Copy link
Author

tukac commented Apr 18, 2021

It seems bug is wrong grep return. lightning-cli listchannels <short channel ID> returns two dictionaries. Values shown in Update Fee Policy are from first dictionary instead of second one.

@ShahanaFarooqui ShahanaFarooqui self-assigned this Apr 18, 2021
@ShahanaFarooqui ShahanaFarooqui added bug Something isn't working Core Lightning labels Apr 18, 2021
@ShahanaFarooqui ShahanaFarooqui added this to the Release 0.10.2-beta milestone Apr 18, 2021
ShahanaFarooqui added a commit that referenced this issue Apr 24, 2021
@ShahanaFarooqui
Update Fee Policy Bug Fix #659
2e1eda6 
Update Fee Policy Bug Fix #659
@ShahanaFarooqui ShahanaFarooqui mentioned this issue Apr 24, 2021
Merged
ShahanaFarooqui added a commit that referenced this issue Apr 24, 2021
@ShahanaFarooqui
Update Fee Policy Bug Fix #659 (#665)
069c7bf 
Update Fee Policy Bug Fix #659
@ShahanaFarooqui ShahanaFarooqui linked a pull request Apr 24, 2021 that will close this issue
Update Fee Policy Bug Fix #659 #665
Merged
@ShahanaFarooqui
Copy link
Collaborator

Closing with PR #665

ShahanaFarooqui added a commit that referenced this issue Apr 24, 2021
@ShahanaFarooqui
Release 0.10.2 (#666)
e4d6256 
High CPU usage by browser when session inactivity dialog is showing #624
Block Altcoins #627
Remove slide right animation on route change #642
Update the initiator field for Loop APIs #643
Filter Bug fix #623
Transaction id for pending waiting channel #603
Empty cookie security risk bug fix #610
Material container repositions on Mac Firefox #268 & #619 
Mask config file passwords #636
Downloaded all channels backup fails to restore #614
CLT Routing list disappears on navigation #652
Update Bump Fee modal #628
LND Paying zero amount invoice fails #657
Open channel fails after adding peer with uri #662
Update Fee Policy Bug Fix #659
Changed default password from `changeme` to `password` (#653) (Contributed By: Andrew Leschinsky <andrew@leschinsky.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahanaFarooqui ShahanaFarooqui

Labels
bug Something isn't working Core Lightning
Projects
None yet
Milestone
Release 0.10.2-beta
Development

Successfully merging a pull request may close this issue.

Update Fee Policy Bug Fix #659 Ride-The-Lightning/RTL
2 participants
@ShahanaFarooqui @tukac