Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paying zero amount invoice fails with incorrect_payment_details #657

Closed
mmilata opened this issue Apr 16, 2021 · 1 comment · Fixed by #658
Closed

Paying zero amount invoice fails with incorrect_payment_details #657

mmilata opened this issue Apr 16, 2021 · 1 comment · Fixed by #658
Assignees
@ShahanaFarooqui
Labels
bug Something isn't working enhancement New feature or request LND
Milestone
Release 0.10.2-beta

Comments

@mmilata
Copy link
Contributor

mmilata commented Apr 16, 2021 •
edited
Loading

Describe the bug
Payments to tippin.me (which generates 0sat invoices) fail with incorrect_payment_details.

To Reproduce
Steps to reproduce the behavior:

  1. Go to tippin.me user of your choice, e.g. https://tippin.me/@nobsbitcoin and copy the invoice.
  2. Paste invoice to RTL's Send Payment dialog. Set amount to e.g. 1.
  3. Set fee limit.
  4. See error incorrect_payment_details.

Screenshots
Screenshot_2021-04-16 RTL

Your environment

  • Version of RTL: 0.10.1-beta
  • Version of lnd: 0.12.1-beta
  • Version of bitcoind: 0.21.0
  • Browser & browser version: Firefox 87
  • Operating system (uname -a on *Nix): Linux
  • any other relevant environment details: The LND node has direct channel to tippin.me.

Additional context
The payment succeeds when the same invoice is given to lncli payinvoice --amt 1234 <invoice>.
ShahanaFarooqui added a commit that referenced this issue Apr 16, 2021
@ShahanaFarooqui
LND Paying zero amount invoice fails #657
46dd903 
LND Paying zero amount invoice fails #657
@ShahanaFarooqui ShahanaFarooqui mentioned this issue Apr 16, 2021
Merged
ShahanaFarooqui added a commit that referenced this issue Apr 16, 2021
@ShahanaFarooqui
LND Paying zero amount invoice fails #657 (#658)
851fc52 
LND Paying zero amount invoice fails #657
@ShahanaFarooqui ShahanaFarooqui linked a pull request Apr 16, 2021 that will close this issue
LND Paying zero amount invoice fails #657 #658
Merged
@ShahanaFarooqui ShahanaFarooqui self-assigned this Apr 16, 2021
@ShahanaFarooqui ShahanaFarooqui added bug Something isn't working enhancement New feature or request LND labels Apr 16, 2021
@ShahanaFarooqui ShahanaFarooqui added this to the Release 0.10.2-beta milestone Apr 16, 2021
@ShahanaFarooqui
Copy link
Collaborator

@mmilata Thanks for opening the issue and the details.

After discussion with LND team and on their suggestion, we have updated the JSON body for the send payment POST. Previously, we were passing dest_string and amt details for the empty string. After the fix, we will pass payment_request and amt details for the same.

The issue has been fixed with PR #658. It can be tested from the release branch and will be released with v0.10.2.

ShahanaFarooqui added a commit that referenced this issue Apr 24, 2021
@ShahanaFarooqui
Release 0.10.2 (#666)
e4d6256 
High CPU usage by browser when session inactivity dialog is showing #624
Block Altcoins #627
Remove slide right animation on route change #642
Update the initiator field for Loop APIs #643
Filter Bug fix #623
Transaction id for pending waiting channel #603
Empty cookie security risk bug fix #610
Material container repositions on Mac Firefox #268 & #619 
Mask config file passwords #636
Downloaded all channels backup fails to restore #614
CLT Routing list disappears on navigation #652
Update Bump Fee modal #628
LND Paying zero amount invoice fails #657
Open channel fails after adding peer with uri #662
Update Fee Policy Bug Fix #659
Changed default password from `changeme` to `password` (#653) (Contributed By: Andrew Leschinsky <andrew@leschinsky.com>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShahanaFarooqui ShahanaFarooqui

Labels
bug Something isn't working enhancement New feature or request LND
Projects
None yet
Milestone
Release 0.10.2-beta
Development

Successfully merging a pull request may close this issue.

LND Paying zero amount invoice fails #657 Ride-The-Lightning/RTL
2 participants
@mmilata @ShahanaFarooqui