Forward query allocation and aggregate the results #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcaballeros
reviewed
Oct 27, 2020
| * | ||
| * Ask @query to the downstream element. | ||
| * | ||
| * Return: True if the query was successfull, False otherwise. |
jcaballeros
approved these changes
Oct 27, 2020
This will forward the query allocation when received between the connected listeners and aggregates the results of each listeners. This helps to indicate the upstream elements which metas are supported. For example it avoids v4l2src buffer copy when the downstream elements doesn't report that video meta is supported and the pitch is different than width.
mmontero
force-pushed
the
feature/query-allocation
branch
from
74e4f6a
to
1e2c41d
Compare
|
Why has this pull request not being accepted? Is there a reason why the interpipe should not handle the allocation query in this way? The behaviour is the same as gsttee.c, which makes sense to me, but maybe I am missing something... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will forward the query allocation when received
between the connected listeners and aggregates the
results of each listeners. This helps to indicate
the upstream elements which metas are supported.
For example it avoids v4l2src buffer copy when the
downstream elements doesn't report that video meta
is supported and the pitch is different than width.