Unsave already saved songs with 's' #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to add a confirmation prompt for this potentially destructive action? |
Rigellute
reviewed
Oct 25, 2019
src/app.rs
Outdated
| if let Some(spotify) = &self.spotify { | ||
| match spotify.current_user_saved_tracks_contains(&[track_id.clone()]) { | ||
| Ok(saved) => { | ||
| if saved[0] { |
There was a problem hiding this comment.
This is probably overkill, but to be safe let's use saved.first() instead of the array accessor [0]. We'd then need to handle the option.
src/app.rs
Outdated
| } | ||
|
|
||
| // Currently unused but keep for future changes | ||
| #[allow(dead_code)] |
There was a problem hiding this comment.
Are you able to delete this? No need to allow dead code (shouldn't exist in master).
|
@alichtman that's an interesting point - let's see how it goes without a prompt. The official Spotify client doesn't throw up a prompt when removing saved tracks, so let's copy that behaviour for now. |
|
@Rigellute I adressed your changes. I also agree that we don't need to confirm this action since it can be made undone very easily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pressing s now toggles the saved state of a song, which allows unsaving songs. Kept the old save_tracks despite it not being used for usage in future changes.