Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache regeneration performance issues #238

Closed
DirtGamer301 opened this issue Jun 6, 2015 · 10 comments
Closed

Cache regeneration performance issues #238

DirtGamer301 opened this issue Jun 6, 2015 · 10 comments

Comments

@DirtGamer301
Copy link

Regenerating the cache in Test Build 3 is waaay slower than in 0.4.0.7.

Also, after regenerating cache manually in 0.4.5.0 every single vehicle will be in the "Fresh" section.

@Max98 Max98 added the bug label Jun 6, 2015
@Max98 Max98 added this to the RoR 0.4.5 (Nextstable) milestone Jun 6, 2015
@DirtGamer301
Copy link
Author

Update/edit:

I tested it again and only noticed a performance issue when manually regenerating cache via RoRConfig.exe.
If you install a new/delete a mod and NextStable automatically regenerates cache there are no performance differences.

@ohlidalp
Copy link
Member

@DirtGamer301 : Try manually erasing the content of Rigs of Rods 0.4/cache directory, then repeat your tests. I think you mixed 2 distinct operations:

  1. Full cache re-generation (RoR config erased cache and launched RoR to regen it)
  2. Incremental (read "partial") update (when you add/remove a mod)

@DirtGamer301
Copy link
Author

I've always pressed on "regen cache", not clear cache, for test 1 and add/removing a vehicle for test 2 as cache clearing takes hours (atleast for me).

@DODGEcharger
Copy link

I haven't noticed any difference in performance between cache regeneration in TB4 and previous versions. If anything I'd say TB4 is a bit quicker at regenerating. :P

@derbymutt
Copy link
Contributor

TB4 is much slower than .4.0.7 at regenning the cache (takes about 10 seconds per mod rather than the 20 or so mods per second in .4.0.7), and usually ends up crashing out for me about 1/4 of the way through, forcing me to regen in .4.0.7.

@Max98
Copy link
Member

Max98 commented Jul 21, 2015

@only-a-ptr The problem is that the new parser actually reads the whole truck file instead of just the sections needed for the cache.(Eg. title, description.. not nodes & beams and stuff) Which results in a slower regen time.

@Olius
Copy link

Olius commented Jul 21, 2015

For me, clicking "clear cache" in the configurator and then launching RoR take around 1~2 mins with 147 mods (the HQ and Content packs for 0.4 and a couple other vehicles). It's definitely slower than 0.4.0.7, but it's far from taking hours for me.

@ohlidalp ohlidalp modified the milestones: Post-Nextstable, RoR 0.4.5 (Nextstable) Jul 22, 2015
@ohlidalp
Copy link
Member

I'll implement a "metadata-only" mode to the parser so that it only reads useful info and works faster.

@Hiradur Hiradur modified the milestones: Post-Nextstable, 0.4.6.0 Oct 24, 2015
@ulteq ulteq removed this from the 0.4.7.0 milestone Oct 7, 2016
@AnotherFoxGuy
Copy link
Member

@only-a-ptr Is this fixed with #1233 ?

@ohlidalp
Copy link
Member

@AnotherFoxGuy Pretty much yes. Let's close this ticket.

Originally I intended to implement a limited parsing mode for cache only, but never got to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants