Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new optional Commands2 parameter 'playsSound' #791

Closed
ulteq opened this issue Feb 22, 2016 · 2 comments
Closed

Add a new optional Commands2 parameter 'playsSound' #791

ulteq opened this issue Feb 22, 2016 · 2 comments
Labels
request
Milestone
0.4.7.0

Comments

@ulteq
Copy link
Contributor

ulteq commented Feb 22, 2016 •
edited

As suggested by @fidoj, we should add a new optional Commands2 parameter playsSound that overrides the default sound emission behavior.
@ulteq ulteq added the request label Feb 22, 2016
@ulteq ulteq changed the title [Request] Adding a new optional Commands2 parameter 'playSound` [Request] Adding a new optional Commands2 parameter 'playsSound` Feb 22, 2016
@ulteq ulteq mentioned this issue Feb 22, 2016
Closed
@graysonk95
Copy link

In case my comment on #787 got overlooked:

"Likewise, could we also get a mute flag?

I would like to add a (working) high idle switch, but in order to do so, the high idle command beam must rev up the engine but not play the pump sound.
(A high idle switch is simulated through the use of a painfully slow command beam).

Voulk's high idle on his Thomas pack utilizes a command to rev up the engine, but he uses no pump sound at all, so his commands are effectively muted.
I use a pump sound on my HDX, so I have no way to do this without the high idle command hissing."

@ulteq
Copy link
Contributor Author

ulteq commented Oct 9, 2016

Likewise, could we also get a mute flag?

playsSound 0 would basically be a mute flag.

@ulteq ulteq added this to the 0.4.7.0 milestone Oct 9, 2016
@ulteq ulteq changed the title [Request] Adding a new optional Commands2 parameter 'playsSound` [Request] Adding a new optional Commands2 parameter 'playsSound' Oct 9, 2016
ulteq added a commit to ulteq/rigs-of-rods that referenced this issue Oct 9, 2016
@ulteq
[Feature] Optional Commands2 parameter 'playsSound'
4aa90b4 
Fixes: RigsOfRods#791
@ulteq ulteq changed the title [Request] Adding a new optional Commands2 parameter 'playsSound' Adding a new optional Commands2 parameter 'playsSound' Oct 9, 2016
@ulteq ulteq changed the title Adding a new optional Commands2 parameter 'playsSound' Add a new optional Commands2 parameter 'playsSound' Oct 9, 2016
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Mar 8, 2017
@ohlidalp
🔧 Audio: Eliminated dead "SoundLink" mechanism.
c62dcd2 
Aside of "trigger source" and "modulation source", a soundscript (code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later).

The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every command. These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them.

The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed.

** COMMANDS2 / PLAY_SOUNDS option **

During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791.
The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Mar 8, 2017
@ohlidalp
🔧 Audio: Eliminated dead "SoundLink" mechanism.
b5e325f 
Aside of "trigger source" and "modulation source", a soundscript (code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later).

The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every `command` (=a player-controlled hydro in RoR jargon). These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them.

The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed.

** COMMANDS2 / PLAY_SOUNDS option **

During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791.
The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Mar 9, 2017
@ohlidalp
🔧 Audio: Eliminated dead "SoundLink" mechanism.
0c442bd 
Aside of "trigger source", "pitch modulation source" and "gain modulation source", a soundscript (in code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later).

The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every `command` (=a player-controlled hydro in RoR jargon). These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them.

The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed.

** COMMANDS2 / PLAY_SOUNDS option **

During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791.
The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Mar 10, 2017
@ohlidalp
🔧 Audio: Eliminated dead "SoundLink" mechanism.
858f50c 
Aside of "trigger source", "pitch modulation source" and "gain modulation source", a soundscript (in code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later).

The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every `command` (=a player-controlled hydro in RoR jargon). These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them.

The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed.

** COMMANDS2 / PLAY_SOUNDS option **

During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791.
The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Mar 17, 2017
@ohlidalp
🔧 Audio: Eliminated dead "SoundLink" mechanism.
e82e428 
Aside of "trigger source", "pitch modulation source" and "gain modulation source", a soundscript (in code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later).

The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every `command` (=a player-controlled hydro in RoR jargon). These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them.

The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed.

** COMMANDS2 / PLAY_SOUNDS option **

During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791.
The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
ohlidalp added a commit to ohlidalp/rigs-of-rods that referenced this issue Mar 28, 2017
@ohlidalp
🔧 Audio: Eliminated dead "SoundLink" mechanism.
25914bd 
Aside of "trigger source", "pitch modulation source" and "gain modulation source", a soundscript (in code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later).

The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every `command` (=a player-controlled hydro in RoR jargon). These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them.

The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed.

** COMMANDS2 / PLAY_SOUNDS option **

During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791.
The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
request
Projects
None yet
Milestone
0.4.7.0
Development

No branches or pull requests
2 participants
@ulteq @graysonk95