forked from RigsOfRods/rigs-of-rods
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🔧 Audio: Eliminated dead "SoundLink" mechanism.
Aside of "trigger source", "pitch modulation source" and "gain modulation source", a soundscript (in code) had 2 more attributes: "sound link type" and "linked item ID". This was apparently designed for unfinished feature 'soundsources3', which was described in truckfile reference on the wiki (I removed it later). The only "sound link type" ever used was SL_COMMAND which was hardcoded against these soundscript names: "tracks/linked/default_command/extend" and "tracks/linked/default_command/retract". For both of them, one instance would be created for every `command` (=a player-controlled hydro in RoR jargon). These soundscripts were never added as defaults and never documented, so I very much doubt anyone ever used them. The respective trigger, "linked_command" could be specified in soundscript file, but there was no way to specify command ID, so it was useless. Removed. ** COMMANDS2 / PLAY_SOUNDS option ** During analyzing the code, I stubmbled upon a feature added by Ulteq in 2016: RigsOfRods#791. The demand was for a commands2 flag to selectively mute the built-in hydropump sound (at least that's the way I understand it in retrospect). Until now, it only silenced the SL_COMMAND sounds (which were probably never used). I changed it to fullfill it's original purpose (hopefully).
- Loading branch information
Showing
4 changed files
with
79 additions
and
136 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.