Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect if terrain not found #2688

Merged
merged 1 commit into from
Feb 17, 2021
Merged

Disconnect if terrain not found #2688

merged 1 commit into from
Feb 17, 2021

Conversation

tritonas00
Copy link
Collaborator

Reported from discord

Disconnect If we are trying to connect to a server and terrain is not found

ohlidalp
ohlidalp approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct fix, but for more elegance please move the disconnect-snippet to main.cpp, to the else branch of if (LoadTerrain()), so that all network manipulations are consistently done from there.

Thanks.

@tritonas00 tritonas00 merged commit 87d7576 into RigsOfRods:master Feb 17, 2021
@tritonas00 tritonas00 deleted the proper-disconnect branch February 17, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohlidalp ohlidalp ohlidalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tritonas00 @ohlidalp