Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up analog dashboard #2899

Merged
merged 2 commits into from
Sep 19, 2022
Merged

Cleaned up analog dashboard #2899

merged 2 commits into from
Sep 19, 2022

Conversation

tritonas00
Copy link
Collaborator

This is Mark3's work from discord. It removes the "leds" section in the analog dashboard which was left from previous versions (image). It interfered with notifications area and made the space cluttered.

Changes:

  • moved the dashboard indicator lights onto the gauges
  • moved "mph" and "kph" on gauge backgrounds
  • fixed the RPM needle angle on 8k tacho
  • fixed the right turn signal indicator jumping position by 2 pixels between on and off
  • re-positioned the boats gauge so it's in the same position as speedo gauge on other vehicles, for consistency

Before:
before1
before2
After:
after1
after2

Copy link
Member

@ohlidalp ohlidalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. You may as well delete the now-unused graphics.

@tritonas00
Copy link
Collaborator Author

tritonas00 commented Sep 15, 2022

You may as well delete the now-unused graphics.

Indeed! Done. Tested, everything seems in place. Just to verify, those deleted:

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/littlelights.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/locked-0.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/locked-1.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/locked-2.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/lopress-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/lopress-on.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/pbrake-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/pbrake-on.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/pbrake-onn.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/redneedle.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/secured-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/secured-on.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/speedo.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/tacho.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/tacho2.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/turbo.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/batt-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/batt-on.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/clutch-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/clutch-on.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/ign-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/ign-on.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/lights-off.png

https://raw.githubusercontent.com/RigsOfRods/rigs-of-rods/c9d0cd5f396ee8183a8e5d0b0d0895fc6eea1e17/resources/dashboards/lights-on.png

@tritonas00 tritonas00 merged commit 8d6c02c into RigsOfRods:master Sep 19, 2022
@tritonas00 tritonas00 deleted the analog branch September 19, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants