New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #466

Merged
merged 8 commits into from Dec 10, 2015

Conversation

Projects
None yet
4 participants
@ulteq
Contributor

ulteq commented Dec 5, 2015

Fixes #1, #28 and improves #220:

  • Replaces the variable physics time step with a fixed time step of 0.5 ms.
  • Reduces the number of threads in the thread pool by half (only when Hyper-Threading is used).
  • Corrects the "calcforward" logic in the inter truck collision code.
  • Improves the efficiency of the multi-threaded inter truck collision code.
  • Reverts this commit: d3ffea0
@Speciesx

This comment has been minimized.

Show comment
Hide comment
@Speciesx

Speciesx Dec 5, 2015

Contributor

"Reduces the number of threads in the thread pool by half."
When i will further use 4 threads on my Quad-Core CPU, what i need to do, set NumThreadsInThreadPool to 4 or 8?

Contributor

Speciesx commented Dec 5, 2015

"Reduces the number of threads in the thread pool by half."
When i will further use 4 threads on my Quad-Core CPU, what i need to do, set NumThreadsInThreadPool to 4 or 8?

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Dec 5, 2015

Contributor

NumThreadsInThreadPool=4

Here is a benchmark map: simpleTest.zip

Contributor

ulteq commented Dec 5, 2015

NumThreadsInThreadPool=4

Here is a benchmark map: simpleTest.zip

@Speciesx

This comment has been minimized.

Show comment
Hide comment
@Speciesx

Speciesx Dec 5, 2015

Contributor

Do you have a Windows Build with your changes?

Contributor

Speciesx commented Dec 5, 2015

Do you have a Windows Build with your changes?

@only-a-ptr

This comment has been minimized.

Show comment
Hide comment
@only-a-ptr

only-a-ptr Dec 5, 2015

Member

👍

Member

only-a-ptr commented on 5ee240b Dec 5, 2015

👍

@ulteq

This comment has been minimized.

Show comment
Hide comment
@ulteq

ulteq Dec 5, 2015

Contributor

Do you have a Windows Build with your changes?

Unfortunately not.

Contributor

ulteq commented Dec 5, 2015

Do you have a Windows Build with your changes?

Unfortunately not.

@Hiradur

This comment has been minimized.

Show comment
Hide comment
@Hiradur

Hiradur Dec 6, 2015

Contributor

👍

Contributor

Hiradur commented Dec 6, 2015

👍

@Speciesx

This comment has been minimized.

Show comment
Hide comment
@Speciesx

Speciesx Dec 8, 2015

Contributor

I've pretty big improvements with Gavril cars, but no with Tatra Dakar.
Updated test with 2, 4 and 6 Tatras.
simpleTest.zip
http://www.rigsofrods.com/repository/view/3686

Contributor

Speciesx commented Dec 8, 2015

I've pretty big improvements with Gavril cars, but no with Tatra Dakar.
Updated test with 2, 4 and 6 Tatras.
simpleTest.zip
http://www.rigsofrods.com/repository/view/3686

only-a-ptr added a commit that referenced this pull request Dec 10, 2015

Merge pull request #466 from ulteq/bugfixes
Signifficant performance improvements by Ulteq

@only-a-ptr only-a-ptr merged commit 83a5513 into RigsOfRods:master Dec 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ulteq ulteq deleted the ulteq:bugfixes branch Dec 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment