Fixed multithreading for good #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohlidalp
force-pushed
the
tired-of-crashes
branch
4 times, most recently
from
0f7d499
to
03183ce
Compare
ohlidalp
force-pushed
the
tired-of-crashes
branch
from
03183ce
to
59977b6
Compare
ohlidalp
force-pushed
the
tired-of-crashes
branch
from
59977b6
to
33d0dfb
Compare
ohlidalp
force-pushed
the
tired-of-crashes
branch
2 times, most recently
from
d96227d
to
b7db3dd
Compare
All script callbacks must be invoked while Sequencer's clients-mutex is locked. This makes the ScriptEngine's context-mutex redundant.
Unsafe methods made private, public threadsafe counterparts were created where needed.
Unsafe methods made private, public threadsafe counterparts were created where needed.
ohlidalp
force-pushed
the
tired-of-crashes
branch
from
b7db3dd
to
8894981
Compare
tritonas00
approved these changes
May 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A distillation of #143 without changes to RoRnet.
Update: This evolved into full-scale audit of thread safety. First I noticed the 'queue client for disconnect' function isn't safe to invoke outside Sequencer, then I discovered many others suffering the same issue.
Update 2: Additionally, I found out the
frameStep()script callback wasn't synchronized with the rest of the server.