Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageDto type is outdated in documentation #102

Closed
junlarsen opened this issue Mar 26, 2019 · 4 comments
Closed

MessageDto type is outdated in documentation #102

junlarsen opened this issue Mar 26, 2019 · 4 comments
Labels
closed: duplicate

Comments

@junlarsen
Copy link

Preconditions

  • Access to the API and a way to request from the API

Steps to reproduce

  1. Request the current ShardData from the Status API

  2. Realize the MessageDto has changed from the one documented on the API page

Expected result

The MessageDto is supposed to match the one in the documentation

Actual result

There have been some field changes. The uploaded_at field is gone and there's a new field named heading
@junlarsen
Copy link
Author

junlarsen commented Mar 26, 2019 •
edited

Additional items missing:

ParticipantStatsDto is missing all the statPerk0-2 titles.

@MingweiSamuel MingweiSamuel mentioned this issue Mar 30, 2019
Closed
@MingweiSamuel MingweiSamuel mentioned this issue Dec 2, 2019
Closed
@MingweiSamuel
Copy link

Seems both these issues still exist

@MingweiSamuel MingweiSamuel mentioned this issue Sep 1, 2020
Closed
MingweiSamuel added a commit to MingweiSamuel/riotapi-schema that referenced this issue Sep 2, 2020
@MingweiSamuel
Override for ParticipantStatsDto to add statPerk0, statPerk1, statPerk2
66b840f 
RiotGames/developer-relations#102
RiotGames/developer-relations#359
This was referenced Sep 15, 2020
Closed
Closed
@RiotTuxedo
Copy link
Contributor

The documentation has been updated. Thanks for the report. Sorry about the delay on this.

@RiotTuxedo
Copy link
Contributor

Duplicate of #79

@RiotTuxedo RiotTuxedo marked this as a duplicate of #79 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed: duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MingweiSamuel @RiotTuxedo @junlarsen