[DOCS] LoL Game Constants JSONs missing newer additions #340

aPinat · 2020-07-23T00:16:57Z

Game constants JSONs over on https://developer.riotgames.com/docs/lol are out of date and cause issues in libraries that use them to parse API responses using the given ids.

Missing from what I can tell are:

SEASON 2020 in seasons.json
queueId 1300 for the current Nexus Blitz in queues.json
gameMode NEXUSBLITZ for the current Nexus Blitz in gameModes.json
mapId 22 for Convergence TFT map in maps.json
(queueId 1111 for 1v0 TFT testing queue)

The text was updated successfully, but these errors were encountered:

MingweiSamuel · 2020-07-23T06:04:47Z

I've created http://www.mingweisamuel.com/riotapi-schema/enums/ which contains the updated enums as well as annotated names and descriptions
MingweiSamuel/riotapi-schema#16

aPinat · 2020-07-23T06:10:38Z

@MingweiSamuel Small error there: Queue 1110 is still TFT Tutorial and1111 (really that number) is that internal TFT 1v0 testing queue.

{
        "allowablePremadeSizes": [
            1
        ],
        "areFreeChampionsAllowed": true,
        "assetMutator": "",
        "category": "PvP",
        "championsRequiredToPlay": 22,
        "description": "Tutorial",
        "detailedDescription": "",
        "gameMode": "TFT",
        "gameTypeConfig": {
            "advancedLearningQuests": false,
            "allowTrades": false,
            "banMode": "SkipBanStrategy",
            "banTimerDuration": 0,
            "battleBoost": false,
            "crossTeamChampionPool": false,
            "deathMatch": false,
            "doNotRemove": false,
            "duplicatePick": false,
            "exclusivePick": false,
            "gameModeOverride": null,
            "id": 19,
            "learningQuests": false,
            "mainPickTimerDuration": 93,
            "maxAllowableBans": 0,
            "name": "GAME_CFG_TEAM_BUILDER_BLIND",
            "numPlayersPerTeamOverride": null,
            "onboardCoopBeginner": false,
            "pickMode": "SimulPickStrategy",
            "postPickTimerDuration": 13,
            "reroll": false,
            "teamChampionPool": false
        },
        "id": 1110,
        "isRanked": false,
        "isTeamBuilderManaged": true,
        "isTeamOnly": false,
        "lastToggledOffTime": 0,
        "lastToggledOnTime": 1582767855885,
        "mapId": 22,
        "maxLevel": 0,
        "maxSummonerLevelForFirstWinOfTheDay": 0,
        "maximumParticipantListSize": 1,
        "minLevel": 0,
        "minimumParticipantListSize": 1,
        "name": "Teamfight Tactics (Tutorial)",
        "numPlayersPerTeam": 8,
        "queueAvailability": "Available",
        "queueRewards": {
            "isChampionPointsEnabled": false,
            "isIpEnabled": true,
            "isXpEnabled": true,
            "partySizeIpRewards": []
        },
        "removalFromGameAllowed": true,
        "removalFromGameDelayMinutes": 0,
        "shortName": "Teamfight Tactics (Tutorial)",
        "showPositionSelector": false,
        "spectatorEnabled": false,
        "type": "TUTORIAL_TFT"
    },
    {
        "allowablePremadeSizes": [
            1
        ],
        "areFreeChampionsAllowed": true,
        "assetMutator": "",
        "category": "PvP",
        "championsRequiredToPlay": 22,
        "description": "",
        "detailedDescription": "",
        "gameMode": "TFT",
        "gameTypeConfig": {
            "advancedLearningQuests": false,
            "allowTrades": false,
            "banMode": "SkipBanStrategy",
            "banTimerDuration": 0,
            "battleBoost": false,
            "crossTeamChampionPool": false,
            "deathMatch": false,
            "doNotRemove": false,
            "duplicatePick": false,
            "exclusivePick": false,
            "gameModeOverride": null,
            "id": 19,
            "learningQuests": false,
            "mainPickTimerDuration": 93,
            "maxAllowableBans": 0,
            "name": "GAME_CFG_TEAM_BUILDER_BLIND",
            "numPlayersPerTeamOverride": null,
            "onboardCoopBeginner": false,
            "pickMode": "SimulPickStrategy",
            "postPickTimerDuration": 13,
            "reroll": false,
            "teamChampionPool": false
        },
        "id": 1111,
        "isRanked": false,
        "isTeamBuilderManaged": true,
        "isTeamOnly": false,
        "lastToggledOffTime": 0,
        "lastToggledOnTime": 0,
        "mapId": 22,
        "maxLevel": 0,
        "maxSummonerLevelForFirstWinOfTheDay": 0,
        "maximumParticipantListSize": 1,
        "minLevel": 0,
        "minimumParticipantListSize": 1,
        "name": "",
        "numPlayersPerTeam": 8,
        "queueAvailability": "PlatformDisabled",
        "queueRewards": {
            "isChampionPointsEnabled": false,
            "isIpEnabled": true,
            "isXpEnabled": true,
            "partySizeIpRewards": []
        },
        "removalFromGameAllowed": true,
        "removalFromGameDelayMinutes": 0,
        "shortName": "",
        "showPositionSelector": false,
        "spectatorEnabled": false,
        "type": "NORMAL_TFT"
    }

RiotGames/developer-relations#340

MingweiSamuel · 2020-07-23T06:14:05Z

Good catch, fixed. Where did you get that JSON from, the LCU?

aPinat · 2020-07-23T06:15:50Z

yeah: /lol-game-queues/v1/queues

ciabo14 · 2020-07-28T05:51:53Z

Hey Folks,

do you know if and when the static data will be updatad in the official repository (https://developer.riotgames.com/docs/lol) as well?

IcyDefiance · 2020-08-02T16:37:59Z

Game modes for the new tutorials are also missing:

TUTORIAL_MODULE_1 (Welcome to League)
- https://na1.api.riotgames.com/lol/match/v4/matches/3432145099
TUTORIAL_MODULE_2 (Power Up)
- https://na1.api.riotgames.com/lol/match/v4/matches/3432116214
TUTORIAL_MODULE_3 (Shop for Gear)
- https://na1.api.riotgames.com/lol/match/v4/matches/3432156790

MingweiSamuel · 2020-08-03T03:19:44Z

@IcyDefiance Updated the mirror http://www.mingweisamuel.com/riotapi-schema/enums/gameModes.json

RiotGames/developer-relations#340

Zelgadis87 · 2020-12-02T15:06:41Z

Static data is still referring to Season 2019 as the current ranked season: http://static.developer.riotgames.com/docs/lol/seasons.json ..

AoshiW · 2020-12-02T15:20:02Z

@Zelgadis87 i don't think they will be updated it.

https://developer.riotgames.com/apis#match-v4/GET_getMatchlist

season		Set[int]	[DEPRECATED] This field should not be considered reliable for the purposes of filtering matches by season.

Zelgadis87 · 2020-12-02T16:30:09Z

@AoshiW Mhmm, that's for the filter parameter, not for the returning match data, which instead have no notes.. Anyway, I suppose you are right, since it's been two years since the last update.. I imagine they have deprecated the season concept entirely from the APIs? I don't really get it why, nor I can find any other reliable data for calculating stats by season...

RiotTuxedo · 2020-12-02T18:42:27Z

We're moving to tracking seasons by timestamp. This will need to be added to the documentation, but until then hopefully this helps.

All times in Pacific Time

Shard  |   Season 2019 Start  |   Season 2019 End    |   Season 2020 Start  |   Season 2020 End
---------------------------------------------------------------------------------------------------
OC1    | 2019-01-23 11:00:00  | 2019-11-18 05:01:00  | 2020-01-09 09:00:00  | 2020-11-09 05:00:01
JP1    | 2019-01-23 11:10:00  | 2019-11-18 07:01:00  | 2020-01-09 11:00:00  | 2020-11-09 07:00:01
KR     | 2019-01-23 11:10:00  | 2019-11-18 07:01:00  | 2020-01-09 11:00:00  | 2020-11-09 07:00:01
RU     | 2019-01-23 16:00:00  | 2019-11-18 13:01:00  | 2020-01-09 17:00:00  | 2020-11-09 13:00:01
TR1    | 2019-01-23 19:00:00  | 2019-11-18 13:01:00  | 2020-01-09 17:00:00  | 2020-11-09 13:00:01
EUN1   | 2019-01-23 18:00:00  | 2019-11-18 15:01:00  | 2020-01-09 19:00:00  | 2020-11-09 15:00:01
EUW1   | 2019-01-23 21:00:00  | 2019-11-18 16:01:00  | 2020-01-09 20:00:00  | 2020-11-09 16:00:01
BR1    | 2019-01-23 23:00:00  | 2019-11-18 19:01:00  | 2020-01-09 23:00:00  | 2020-11-09 19:00:01
LA2    | 2019-01-24 00:00:00  | 2019-11-18 19:01:00  | 2020-01-09 23:00:00  | 2020-11-09 19:00:01
LA1    | 2019-01-24 02:00:00  | 2019-11-18 22:01:00  | 2020-01-10 02:00:00  | 2020-11-09 22:00:01
NA1    | 2019-01-24 03:00:00  | 2019-11-19 00:01:00  | 2020-01-10 04:00:00  | 2020-11-10 00:00:01

As for the rest of the constants. I'll get that updated this week.

MingweiSamuel · 2020-12-02T19:19:59Z

QueueIDs are still a bit weird and sometimes out of date. There are a few different sources of truth that all have different subsets of queues ids:
MingweiSamuel/Camille#36 (comment)

RiotTuxedo · 2020-12-02T20:31:50Z

I'll see if I can go through the other sources and add anything that makes sense. The constants files are manually updated, so if you're using them in a project you should have a default fallback for an unknown queue, gamemode, etc.

MingweiSamuel mentioned this issue Jul 23, 2020

New Nexus Blitz missing in Enum GameMode and Queues causing JSON serialization errors MingweiSamuel/Camille#36

Closed

MingweiSamuel added a commit to MingweiSamuel/riotapi-schema that referenced this issue Jul 23, 2020

Fix queue enum TFT 1V0 id, 1110 -> 1111

dbd4fca

RiotGames/developer-relations#340

MingweiSamuel mentioned this issue Jul 28, 2020

get_matchlist() only with region and summoner account id returns reqwest decode error MingweiSamuel/Riven#18

Closed

MingweiSamuel added a commit to MingweiSamuel/Riven that referenced this issue Aug 3, 2020

Update to use mingweisamuel.com/riotapi-schema/enums

0f9d783

RiotGames/developer-relations#340

MingweiSamuel mentioned this issue Sep 15, 2020

Game Constants JSONs missing newer additions MingweiSamuel/riotapi-schema#21

Open

RiotTuxedo closed this as completed Dec 2, 2020

RiotTuxedo added closed: resolved scope: lol topic: documentation type: inconsistency Typos, dead links, out dated information, or weird behavior. labels Dec 2, 2020

aPinat mentioned this issue Nov 19, 2021

[DOCS] Update LoL game constants JSONs to include newer live and PBE additions #574

Open

MingweiSamuel mentioned this issue Apr 11, 2022

[DOCS][BUG] PRACTICETOOL missing from gameModes.json #623

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DOCS] LoL Game Constants JSONs missing newer additions #340

[DOCS] LoL Game Constants JSONs missing newer additions #340

aPinat commented Jul 23, 2020

MingweiSamuel commented Jul 23, 2020 •

edited

aPinat commented Jul 23, 2020 •

edited

MingweiSamuel commented Jul 23, 2020

aPinat commented Jul 23, 2020

ciabo14 commented Jul 28, 2020

IcyDefiance commented Aug 2, 2020

MingweiSamuel commented Aug 3, 2020

Zelgadis87 commented Dec 2, 2020

AoshiW commented Dec 2, 2020

Zelgadis87 commented Dec 2, 2020

RiotTuxedo commented Dec 2, 2020 •

edited

MingweiSamuel commented Dec 2, 2020

RiotTuxedo commented Dec 2, 2020

[DOCS] LoL Game Constants JSONs missing newer additions #340

[DOCS] LoL Game Constants JSONs missing newer additions #340

Comments

aPinat commented Jul 23, 2020

MingweiSamuel commented Jul 23, 2020 • edited

aPinat commented Jul 23, 2020 • edited

MingweiSamuel commented Jul 23, 2020

aPinat commented Jul 23, 2020

ciabo14 commented Jul 28, 2020

IcyDefiance commented Aug 2, 2020

MingweiSamuel commented Aug 3, 2020

Zelgadis87 commented Dec 2, 2020

AoshiW commented Dec 2, 2020

Zelgadis87 commented Dec 2, 2020

RiotTuxedo commented Dec 2, 2020 • edited

MingweiSamuel commented Dec 2, 2020

RiotTuxedo commented Dec 2, 2020

MingweiSamuel commented Jul 23, 2020 •

edited

aPinat commented Jul 23, 2020 •

edited

RiotTuxedo commented Dec 2, 2020 •

edited