Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update LoL game constants JSONs to include newer live and PBE additions #574

Open
aPinat opened this issue Nov 19, 2021 · 3 comments

Comments

@aPinat
Copy link

aPinat commented Nov 19, 2021

Requesting update to https://static.developer.riotgames.com/docs/lol/queues.json.

Changes (also ref to my last issue #340):

  • Queues 1901/1902 are in use for 1v0/2v0 TFT games on PBE instead of the previous 1111 queue which is now named "TFT Simlulation" in LCU, so I updated description below to match that.
  • 1130/1150 being TFT Hyper Roll and Double Up Beta on Live and PBE.
  • Updated notes for 1200 to include new queueId for it for consistency with all other queues with the same deprecation note and still live on new ID.
{
    "queueId": 1091,
    "map": "Convergence",
    "description": "Teamfight Tactics 1v0 games",
    "notes": null
},
{
    "queueId": 1092,
    "map": "Convergence",
    "description": "Teamfight Tactics 2v0 games",
    "notes": null
},
{
    "queueId": 1111,
    "map": "Convergence",
    "description": "Teamfight Tactics Simluation games",
    "notes": null
},
{
    "queueId": 1130,
    "map": "Convergence",
    "description": "Teamfight Tactics (Hyper Roll) games",
    "notes": null
},
{
    "queueId": 1150,
    "map": "Convergence",
    "description": "Teamfight Tactics (Double Up Beta) games",
    "notes": null
},
{
    "queueId": 1200,
    "map": "Nexus Blitz",
    "description": "Nexus Blitz games",
    "notes": "Deprecated in patch 9.2 in favor of queueId 1300"
}

Maybe it would also be helpful to add a queueTypes.json with example below, as the "Ranked Info - Queue Types" part of the docs seam out of date as well and with the surprise addition of Double Up Beta as a Ranked mode, it may be easier to maintain for some libraries etc.

[
    {
        "queueType": "RANKED_SOLO_5x5",
        "queueId": 420,
        "description": "5v5 Ranked Solo games",
        "notes": null
    },
    {
        "queueType": "RANKED_FLEX_SR",
        "queueId": 440,
        "description": "5v5 Ranked Flex games",
        "notes": null
    },
    {
        "queueType": "RANKED_FLEX_TT",
        "queueId": 470,
        "description": "3v3 Ranked Flex games",
        "notes": "Deprecated in patch 9.23"
    },
    {
        "queueType": "RANKED_TFT",
        "queueId": 1100,
        "description": "Ranked Teamfight Tactics games",
        "notes": null
    },    {
        "queueType": "RANKED_TFT_TURBO",
        "queueId": 1130,
        "description": "Ranked Teamfight Tactics (Hyper Roll) games",
        "notes": null
    },
    {
        "queueType": "RANKED_TFT_PAIRS",
        "queueId": 1150,
        "description": "Ranked Teamfight Tactics (Double Up Beta) games",
        "notes": null
    }
]

@MingweiSamuel
Copy link

Thanks for taking the lead on this @aPinat

Logically the queueTypes for LoL vs TFT ought to be separate, but it seems they are very much mixed together internally as evidenced by #572.

@aPinat
Copy link
Author

aPinat commented Nov 20, 2021

Agreed, but since they are both practically a part of LoL and both use LoL infrastructure, and with queues.json also containing TFT queues, I thought to put them together for queueTypes too.

@aPinat
Copy link
Author

aPinat commented Jun 20, 2022

Double Up is RANKED_TFT_DOUBLE_UP now on queue 1160 with TFT Set 7.
Updated JSONs from above could look like this:

    {
        "queueId": 1150,
        "map": "Convergence",
        "description": "Ranked Teamfight Tactics (Double Up Workshop) games",
        "notes": "Deprecated in patch 12.11 in favor of queueId 1160"
    },
    {
        "queueId": 1160,
        "map": "Convergence",
        "description": "Ranked Teamfight Tactics (Double Up Workshop) games",
        "notes": null
    },
    {
        "queueType": "RANKED_TFT_PAIRS",
        "queueId": 1150,
        "description": "Ranked Teamfight Tactics (Double Up Workshop) games",
        "notes": "Deprecated in patch 12.11 in favor of queueId 1160"
    },
    {
        "queueType": "RANKED_TFT_DOUBLE_UP",
        "queueId": 1160,
        "description": "Ranked Teamfight Tactics (Double Up Workshop) games",
        "notes": null
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants