Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for AddBytes method #128

Closed
megalithos opened this issue Dec 23, 2023 · 1 comment
Closed

Suggestion for AddBytes method #128

megalithos opened this issue Dec 23, 2023 · 1 comment
Assignees
Labels
Feature Request New feature or request

Comments

@megalithos
Copy link

Maybe AddBytes could get parameters for length & start position, so that if you are pooling arrays with ArrayPool or just have a large buffer, you don't have to just allocate new array with new keyword to be able to add the original byte array to the message.

@tom-weiland tom-weiland added the Feature Request New feature or request label Dec 24, 2023
@tom-weiland
Copy link
Collaborator

Good idea. I think it'd be sufficient to add this only for byte arrays—other types don't really need this, or would you disagree? I'm no longer actively working on this project, but maybe @xzippyzachx is interested in adding this? Or perhaps you'd be willing to do it yourself and make a PR? Just make sure to follow the contributing guidelines.

@xzippyzachx xzippyzachx self-assigned this Jan 25, 2024
xzippyzachx added a commit that referenced this issue Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants