Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ack message sending redundant sequence ID #130

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Fix ack message sending redundant sequence ID #130

merged 1 commit into from
Jan 7, 2024

Conversation

RudyTheDev
Copy link
Contributor

In SendAck() the braces were missing around the else block, so it's always appending the sequence id ushort to the ack message, which isn't used in HandleAck() later if the bool was actually false.

@tom-weiland tom-weiland added the Bug Something isn't working label Jan 7, 2024
@xzippyzachx xzippyzachx merged commit 8bbaa3e into RiptideNetworking:main Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzippyzachx xzippyzachx xzippyzachx approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RudyTheDev @xzippyzachx @tom-weiland