-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code improvements for media pages #176
Code improvements for media pages #176
Conversation
AlbumsPage has DataTemplate related bugs as of now - mostly hangs and memory leaks when switching, and the template not applying sometimes. Switching to a custom control there is likely necessary, will add that within the next few commits. |
…ifferent kinds of items from the same ViewModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but there are some changes that need to be addressed before merging.
Also, use the |
Should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolved / Related Issues
Closely related to #160
Details of Changes
This pull request aims to make the app follow the MVVM pattern more closely, which involves:
Validation
Not yet finished.
Screenshots / Videos (optional)
Not necessary, at least for now.