-
Notifications
You must be signed in to change notification settings - Fork 103
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(displayname): add displayName before React.memo
- Loading branch information
1 parent
7a0346f
commit 52f3ff3
Showing
6 changed files
with
64 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,42 @@ | ||
import React from "react"; | ||
import { view, store } from "react-easy-state"; | ||
import Card from "@material-ui/core/Card"; | ||
import CardMedia from "@material-ui/core/CardMedia"; | ||
import CardContent from "@material-ui/core/CardContent"; | ||
import React from 'react'; | ||
import { view, store } from 'react-easy-state'; | ||
import Card from '@material-ui/core/Card'; | ||
import CardMedia from '@material-ui/core/CardMedia'; | ||
import CardContent from '@material-ui/core/CardContent'; | ||
|
||
// this is re-rendered whenever the relevant parts of the used data stores change | ||
export default view( | ||
({ name, description, image_url: imageUrl, food_pairing: foodPairing }) => { | ||
const beer = store({ details: false }); | ||
const Beer = ({ | ||
name, | ||
description, | ||
image_url: imageUrl, | ||
food_pairing: foodPairing, | ||
}) => { | ||
const beer = store({ details: false }); | ||
|
||
return ( | ||
<Card onClick={() => (beer.details = !beer.details)} className="beer"> | ||
{!beer.details && <CardMedia image={imageUrl} className="media" />} | ||
<CardContent> | ||
<h3>{name}</h3> | ||
{beer.details ? ( | ||
<p>{description}</p> | ||
) : ( | ||
<ul> | ||
{foodPairing.map(food => ( | ||
<li key={food}>{food}</li> | ||
))} | ||
</ul> | ||
)} | ||
</CardContent> | ||
</Card> | ||
); | ||
} | ||
); | ||
return ( | ||
<Card | ||
onClick={() => { | ||
beer.details = !beer.details; | ||
}} | ||
className="beer" | ||
> | ||
{!beer.details && ( | ||
<CardMedia image={imageUrl} className="media" /> | ||
)} | ||
<CardContent> | ||
<h3>{name}</h3> | ||
{beer.details ? ( | ||
<p>{description}</p> | ||
) : ( | ||
<ul> | ||
{foodPairing.map(food => ( | ||
<li key={food}>{food}</li> | ||
))} | ||
</ul> | ||
)} | ||
</CardContent> | ||
</Card> | ||
); | ||
}; | ||
|
||
export default view(Beer); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,17 @@ | ||
import React from "react"; | ||
import { view } from "react-easy-state"; | ||
import appStore from "./appStore"; | ||
import Beer from "./Beer"; | ||
import React from 'react'; | ||
import { view } from 'react-easy-state'; | ||
import appStore from './appStore'; | ||
import Beer from './Beer'; | ||
|
||
// this is re-rendered whenever the relevant parts of the used data stores change | ||
export default view(() => ( | ||
const BeerList = () => ( | ||
<div className="beerlist"> | ||
{!appStore.beers.length ? ( | ||
<h3>No matching beers found!</h3> | ||
) : ( | ||
appStore.beers.map(beer => <Beer key={beer.name} {...beer} />) | ||
)} | ||
</div> | ||
)); | ||
); | ||
|
||
export default view(BeerList); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters